Skip to content
This repository has been archived by the owner on Oct 24, 2022. It is now read-only.

Play 2.4 Upgrade #207

Closed
JPrevost opened this issue Jun 1, 2015 · 1 comment · Fixed by #224
Closed

Play 2.4 Upgrade #207

JPrevost opened this issue Jun 1, 2015 · 1 comment · Fixed by #224
Assignees
Milestone

Comments

@JPrevost
Copy link
Member

JPrevost commented Jun 1, 2015

No description provided.

@JPrevost JPrevost added this to the m7 milestone Jun 1, 2015
@JPrevost
Copy link
Member Author

JPrevost commented Jun 8, 2015

Progress update:

I've got what appears to be a set of changes necessary to upgrade to 2.4 final. I'll get a PR in on it tomorrow if all goes well after I have more time to understand the changes to the logging that 2.4 final introduced. So far it looks like the logging defaults were changed to spit out more errors to STDOUT so we were seeing what looked like errors in the tests. However, all of the tests were actually passing (after a few tweaks involving Evolutions, etc). Filtering out errors from STDOUT cleans up testing, but I'd prefer to only filter those out in the TEST ENV which is why I'm not pushing a commit quite yet.

JPrevost added a commit that referenced this issue Jun 9, 2015
- updates a few dependencies
- configures logging to suppress some excessive noise
— ideally, we’d have separate logback.xml configs for test, dev and
prod. I tried and failed to make that happen. See #222. This
config is largely the default settings with a few additional lines
added to suppress unwanted noise during testing:
See also:
https://www.playframework.com/documentation/2.4.x/SettingsLogger

closes #207
@JPrevost JPrevost mentioned this issue Jun 9, 2015
@JPrevost JPrevost assigned JPrevost and unassigned richardrodgers Jun 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants