Adds delivery count badge to Subscribe button on topic page #123
Conversation
|
I think this is good, but have a concern as to whether it does what your intent for this feature is. My understanding is you want to expose to the Subscriber what will happen when they click a Subscribe button. However, I think there are cases where that won't be accurate. As written this will tell the user the MAX number of Items that will be delivered under a new Subscription, but not necessarily the Actual value due to potential overlapping Items from other Subscriptions. It's even possible that, for example, a new Subscription for an Orcid will deliver nothing at all if the Subscriber has already Subscribed to all of the Institutional Affiliation Names in which that Orcid has ever appeared regardless of whether said Orcid has appeared in a dozen Items since the Subscriber signed up. (Unless I'm misunderstanding what you explained when I opened #119). |
|
The intent here is largely just to explore how the UI should expose contextual data the hub holds. We would refine the calculation as needed. In this case, I think it's not so much overlapping subscriptions or any indeterminacy in the number (max vs actual), since any existing subscriptions would have already been delivered at page render time (put another way, when the button was pushed, the delivery is essentially over) - rather it is the number currently displayed less those already delivered (by any means, including manual deposits). I can certainly add that math now, but I was holding off until we settled a few other things (e.g. API for transfer counts in #115). But thanks for the close read, and I'm more than happy to sit on this until we can sort out these surrounding issues) |
|
Nah, I'd say merge it and we can adjust as our APIs make it easier for sure. 👍 |
Adds delivery count badge to Subscribe button on topic page
closes #122