Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splash screen #44

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Splash screen #44

merged 1 commit into from
Sep 29, 2020

Conversation

rchtgpt
Copy link
Member

@rchtgpt rchtgpt commented Sep 29, 2020

Issue Fix

Fixes #22

Screenshots

Description

Splash screens are typically used to communicate to the user that the program is in the process of loading.

Reviewers

@Imperial-lord @ajitesh13

@ajitesh13
Copy link
Collaborator

How about a thin rectangle, of the same color around "Soochit" with some slight border radius. What do you think ?

@rchtgpt
Copy link
Member Author

rchtgpt commented Sep 29, 2020

How about a thin rectangle, of the same color around "Soochit" with some slight border radius. What do you think ?

The splash screen is 70% of the times not visible. Even when it is, there's only a second to see what's on the screen. So, at least for now, I think this works. @Imperial-lord views?

@ajitesh13
Copy link
Collaborator

Ok, I agree with you, if required, we can edit those things later

@ajitesh13 ajitesh13 merged commit 8e9e90b into MLH-Fellowship:master Sep 29, 2020
@rchtgpt rchtgpt deleted the splash-screen branch September 29, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add App Name on Splash Screen
2 participants