Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exported imports for several Alamofire types. #77

Merged
merged 1 commit into from
May 4, 2020

Conversation

DenTelezhkin
Copy link
Member

@DenTelezhkin DenTelezhkin commented Apr 29, 2020

While TRON is a wrapper around Alamofire API's, several of Alamofire types have been exposed through TRON interface, forcing a user to explicitly write import Alamofire along with import TRON to use them.

It's possible to write an implicit import, that exports entire framework to another framework users(see example, advanced example). TRON - Alamofire situation is a little different, however, since TRON wraps some API's and discourages user from using Alamofire API's directly.

Therefore, this PR aims to export only specific types from Alamofire, that are actually exposed by TRON API.

Downside of this PR is that if TRON API user had local API's that clash with Alamofire naming(for example, local Session type, or local Request type), this change would actually be breaking and would require to explicitly disambiguate those types(Alamofire.Request).

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files          32       32           
  Lines        1488     1488           
=======================================
  Hits         1275     1275           
  Misses        213      213           

@DenTelezhkin DenTelezhkin merged commit ae84494 into master May 4, 2020
@DenTelezhkin DenTelezhkin deleted the exported-import branch May 4, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant