-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for async/await. #78
Conversation
Codecov Report
@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 72.77% 72.98% +0.21%
==========================================
Files 14 15 +1
Lines 786 944 +158
Branches 362 439 +77
==========================================
+ Hits 572 689 +117
- Misses 206 242 +36
- Partials 8 13 +5 |
@DenTelezhkin what's the status on Swift Concurrency support for TRON? Will it eventually be supported? Btw, thanks for your work on this package. It makes working with Alamofire so much more bearable. |
Hi, @kiritokatklian! Thanks for asking. Current PR was a proof of concept I made to see how Structured Concurrency can work in TRON package, however I did not feel confident enough shipping this, as I did not actually use Structured Concurrency in any project yet. So I left this PR hanging (while it seems to be working perfectly fine) until now. Now that i know that there is some interest in community in supporting this, I will definitely prioritize this more. Currently unresolved questions for me are about cancellation properly integrated with Structured Concurrency and usage of Task API (which should be updated to newer syntax). Alamofire approach to those API's is creating DataTask, and returning 3 kinds of possible results - If you have any input on how those API should be structured, would love any feedback as well, since my knowledge of Concurrency is limited by WWDC sessions, and not real world usage, unfortunately (for now, at least :) ). |
…ing creation of DownloadAPIRequest objects.
9baa36f
to
8330665
Compare
…ent even though request was stubbed.
… iOS 11, tvOS 11, watchOS 4, macOS 10.13, as supported by Xcode 14.
…ely on single async event instead of possible two.
@kiritokatklian I've released support for Swift Concurrency in 5.5.0 beta release. If you have any issues / suggestions, please let me know. |
Also add methods to download API for simplifying creation of DownloadAPIRequest objects.