-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GraphQL variables #291
Conversation
88f17a7
to
93fe6c0
Compare
@lpinca not sure if you're the primary guy, but wanted to see if you know why the coverage test is failing? |
probably because the additional if branch you added is not covered by a test. |
@lpinca hey luigi. cana you decide on this PR? |
I will not review it until checks are green. |
FWIW I'm 👍 on the feature. I suggested it when GraphQL support was added. See #282 (comment). |
Got tests passing. |
@lpinca merge? |
Thanks, I will take a look when a I can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep the limit of 80 chars per line and be consistent with other test descriptions.
6523dd2
to
098d3ae
Compare
@lpinca resolved conflicts - your updates should all be there. |
Now they should be there. |
Thank you. |
Yeah, something happened with the merge conflicts :-/ All good now. Thanks for approving! |
Just want to express my gratitude for this code - exactly what I needed! It will tidy up my string literals and also enable me to use types in my code! 🙏 |
This PR allows specifying GraphQL variables to the request. Keeps backward-compatibility.