-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App 樣式調整及首頁 UI #41
Merged
Merged
App 樣式調整及首頁 UI #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Wuchiwei
commented
Jul 19, 2019
•
edited by keith222
Loading
edited by keith222
- 建立以 Tab bar 為基礎的新版介面
- 根據新版 UI 調整首頁樣式
- 新增 SelectionView,作為 view component
modified: Mopcon/Mopcon.xcodeproj/project.pbxproj [Reason] Add new file Lobby.Storyboard, TabViewController and ColorSet folder in Assets. new file: Mopcon/Mopcon/Assets.xcassets/Color/Contents.json renamed: Mopcon/Mopcon/Assets.xcassets/themeColor.colorset/Contents.json -> Mopcon/Mopcon/Assets.xcassets/Color/themeColor.colorset/Contents.json [Reason] Add Color folder in asset for manage color theme. new file: Mopcon/Mopcon/Controller/TabBar/TabViewController.swift renamed: Mopcon/Mopcon/Storyboard/Base.lproj/Main.storyboard -> Mopcon/Mopcon/Storyboard/Base.lproj/Lobby.storyboard new file: Mopcon/Mopcon/Storyboard/Main.storyboard [Reason] Add new Storyboard for new UI requirement.
2. Add tab relative image in Assets 3. Add UIImage extension for image usage. 4. Add UIColor extension for color usage.
2. Add icon for LobbyCollectionViewCell 3. Manipulate UICollectionView collecitonViewLayout object in LobbyViewController. 4. Adject item size by UICollectionView's frame and UICollectionViewDelegateFlowLayout.
…lections will be cut. modified: Mopcon/Storyboard/Base.lproj/Lobby.storyboard
Wuchiwei
force-pushed
the
feature/home-page
branch
from
July 19, 2019 03:21
a0f24c9
to
67b7eeb
Compare
keith222
reviewed
Jul 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
阿...不是 PR 到這個 branch,是 develop 唷(我之前也眼殘推錯幾次 QQ
@bbandydd 想問 developer 這個 branch 還有留存的需要嗎?不然偶爾會眼殘按錯 XD
Sorry, 已修正。 |
2. Add UIView extension. modified: Mopcon/Mopcon.xcodeproj/project.pbxproj new file: Mopcon/Mopcon/Helper/Exntension/UIViewExtension.swift new file: Mopcon/Mopcon/View/Common/SelectionView.swift
Hi @bbandydd , 不知道這個 PR 是否還有要修正的地方呢? |
developer砍掉吧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.