Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various pieces of clean up #875

Merged
merged 6 commits into from
Apr 21, 2022
Merged

Various pieces of clean up #875

merged 6 commits into from
Apr 21, 2022

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Apr 20, 2022

  1. Gets rid of __future__ imports
  2. Gets rid of six
  3. Removes folds (# {{{ and # }}})
  4. Converts all docstrings to triple quotes, rather than triple single-quotes
  5. Updates the copyright year to 2022

closes #866
closes #867

@pep8speaks
Copy link

pep8speaks commented Apr 20, 2022 •
edited
Loading

Hello @xylar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-04-20 20:13:17 UTC

@xylar xylar added the clean up label Apr 20, 2022
@xylar xylar self-assigned this Apr 20, 2022
@xylar
Copy link
Collaborator Author

xylar commented Apr 21, 2022

The test suite ran successfully on Anvil:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis_testing/anvil/clean_up_pr/

@xylar xylar merged commit 8f29c53 into MPAS-Dev:develop Apr 21, 2022
@xylar xylar deleted the clean_up_pr branch April 21, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xylar xylar

Labels
clean up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of __future__ imports Get rid of vim folds
2 participants
@xylar @pep8speaks