-
Notifications
You must be signed in to change notification settings - Fork 0
Adds LIGHT super-cycling capability #1484
Adds LIGHT super-cycling capability #1484
Conversation
Note, interval should be a multiple of timestep, e.g., For n as an integer config_AM_lagrPartTrack_compute_interval = n*config_dt
@vanroekel, files from this branch will be needed for application of LIGHT to the 18to6. |
I've confirmed that the LIGHT and nightly test suites pass relative to ocean/develop. |
Passes nightly regression suite on grizzly with gnu/opt and intel/debug. All bfb with previous commit, as expected. @pwolfram Does this need any corresponding changes in E3SM, such as any change in namelist flag settings? |
@mark-petersen, we will need to change namelist and streams files for E3SM once we have the performance fully sorted out. I'm currently testing an approach to reduce restart cost. I don't think that effort should hold up this PR. |
@mark-petersen and @pwolfram do the potential name list changes imply that LIGHT will be on by default in E3SM runs? If so, I think this requires a much broader discussion than here. I’m pretty uncomfortable with LIGHT on by default for E3SM. |
@vanroekel, I think there quite a few challenges that would need surmounted before it could be on by default. I'm also not comfortable myself with this notion until I can demonstrate enhanced performance for IO and then there are other software engineering tasks that would also likely need to be completed first too. I'm afraid we are on a tangent here that is not pertinent to this PR. |
I get it. The take-home message is that we can merge this PR and not have any repercussions in E3SM for standard configurations. Correct? |
Correct
…________________________________
From: Mark Petersen <notifications@github.com>
Sent: Wednesday, January 10, 2018 5:37:31 PM
To: MPAS-Dev/MPAS
Cc: Phillip J. Wolfram; Mention
Subject: Re: [MPAS-Dev/MPAS] Adds LIGHT super-cycling capability (#1484)
I get it. The take-home message is that we can merge this PR and not have any repercussions in E3SM for standard configurations. Correct?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1484 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEGMrZ2tPWnsZ2bUd6Fl7t4fxE45a8aoks5tJVfLgaJpZM4RYX3->.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks fine. I will merge it after E3SM-Project/E3SM#1971 is in ACME, probably later today.
@vanroekel mentioned that this PR works on grizzly but had a problem on other machines. @pwolfram, I'd like to postpone this merge until we can confirm that it works on machines like theta and titan. |
This will be included in the next batch of small fixes for MPAS in E3SM, most likely on Feb 8. |
This merge provides the capability to do LIGHT super-cycling.
An example use case is
namelist changes
example particle file changes: