Increase config_Redi_min_layers_diag_terms to 8
#329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on testing with the EC30to60 mesh, this seems necessary to avoid spurious surface temperature extrema.
xylar
added
bug
|
In my testing of EC30to60, this change is needed to fully address #308. |
TestingWhen I cherry-pick #328 onto this branch, EC30to60 now passes the validation of |
|
I also tried |
|
@mark-petersen, would you like to see further testing of this PR? I will test #309 and #310 again once this and #328 are merged. |
mark-petersen
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
It makes sense that some meshes need a higher value for config_Redi_min_layers_diag_terms. I tuned that setting to a low value that worked for the WC14 mesh. Approving based on @xylar's experience with the EC60to30 here. Thanks.
|
Thanks @mark-petersen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on testing with the EC30to60 mesh, this seems necessary to avoid spurious surface temperature extrema.