-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix land-locked cells at calving fronts #752
Fix land-locked cells at calving fronts #752
Conversation
If there are land-locked cells at calving fronts of ice shelves, they need to be added to the land-ice mask so sea-ice doesn't get trapped there. This merge also gets the minimum latitude and number of sweeps used in finding land-locked cells from config options.
dsMask = add_land_locked_cells_to_mask( | ||
dsMask, dsCulledMesh, latitude_threshold=latitude_threshold, | ||
nSweeps=sweep_count) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 3 lines are the real fix here. The rest is clean up to reduce the number of hard-coded parameters.
@mark-petersen, this would be nice to get merged. Would you be able to take a look at these 2 meshes:
and tell me if you think the land-locked cells at calving fronts are fixed (as in the plots I made above)? Also, if you can follow the Compass code changes I made, it would be great to know if they look right to you. |
Thanks. I can see why this would be a problem for sea ice getting caught in the calving front. It's great that the solution is a simple additional call to |
Does it matter if there is a cell with |
Thanks so much @mark-petersen! I lost track of this but I really appreciate your review.
No, that's perfectly fine, just a little odd. It won't have melt fluxes because I'm only updating
Right, with the added factor that the land ice also won't melt there, the cell is just insulated from the atmosphere. This is clearly much better than having trapped but thermodynamically active sea ice. |
If there are land-locked cells at calving fronts of ice shelves, they need to be added to the land-ice mask so sea-ice doesn't get trapped there.
This merge also gets the minimum latitude and number of sweeps used in finding land-locked cells from config options.
Checklist
Testing
in this PR) any testing that was used to verify the changescloses #746