Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only make tidal mixing files for meshes with cavities #798

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Mar 19, 2024

Since the tidal model used to produce the dataset only covers the Southern Ocean, there is not much value in having the reampped dataset for meshes without cavities. If we want to make a more general mixing parameterization that uses tidal information, we would need to use data from a global tidal model for the input dataset in the future.

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

Since the tidal model used to produce the dataset only covers the
Southern Ocean, there is not much value in having the reampped
dataset for meshes without cavities.  If we want to make a more
general mixing parameterization that uses tidal information, we
would need to use data from a global tidal model for the input
dataset in the future.
@xylar xylar self-assigned this Mar 19, 2024
@xylar
Copy link
Collaborator Author

xylar commented Mar 19, 2024

Testing

I ran remap_tidal_mixing from the generic file_for_e3sm test case using both the IcoswISC30E3r5 and IcosXISC30E3r7 meshes, with and without cavities, respectively. In the former case, the following files were produced, as expected:

map_S71W70_CATS_ustar_to_IcoswISC30E3r5_bilinear.nc
velocityTidalRMS_CATS2008_after_remap.nc
velocityTidalRMS_CATS2008.nc

In the latter case, no files were produced, as expected.

@xylar
Copy link
Collaborator Author

xylar commented Mar 19, 2024

@xylar xylar merged commit 1199665 into MPAS-Dev:main Mar 19, 2024
4 checks passed
@xylar xylar deleted the only-write-tmix-wisc branch March 19, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant