Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin attempts not reset upon success fix #2590

Merged
merged 1 commit into from
Aug 29, 2017
Merged

Pin attempts not reset upon success fix #2590

merged 1 commit into from
Aug 29, 2017

Conversation

RaJiska
Copy link
Contributor

@RaJiska RaJiska commented Aug 29, 2017

Not closing the $stmt was triggering a SQLi error and was not reseting the failed pin count when user managed to get it right.

The SQL error:

Commands out of sync; you can't run this command now

@TheSerapher
Copy link
Contributor

Thanks for your PR! If you'd like it merged please recreate this PR against the development branch and I get it merged right away!

@RaJiska RaJiska changed the base branch from master to development August 29, 2017 18:11
@RaJiska
Copy link
Contributor Author

RaJiska commented Aug 29, 2017

There we go, I just edited this one instead of creating a new one. Should work.

@TheSerapher TheSerapher merged commit 7b6aa48 into MPOS:development Aug 29, 2017
@TheSerapher
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants