Multiple fixes for MMS #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
June 26, 2018 15:08
Corrects the VAN_GENUCHTEN parameters for connection auxvars
Changes include: - True pressure for root and xylem are changed - Root and xylem saturation function are set equal to that of soil - Adds command line option to save true solution
Modifies the parameter that downregulates the potential transpiration, so the downregulation factor not approximately equal to 1.0. Also, specifies good initial condition value for xylem pressure.
…problem Problem now uses FETCH2 saturation function and Weibull relative permeability function for root and xylem domain
- Reduces input arguments to ThermalEnthalpyFlux() and ThermalEnthalpyFluxDerivativeWrtPressure() by using derived types - The derivative of residual TH equation w.r.t. pressure now accounts for derivative of thermal conductivity w.r.t. pressure - The OffDiagJacobian_Pressure_ForInternalAuxVars() now accounts for BC that are not COND_DIRICHLET_FRM_OTR_GOVEQ
- First and second spatial derivatives of density are computed numerically - Spatial derivative of Kersten number is corrected - Corrects the use of density_type when computing mass source for pressure equation
This reverts commit d3f249b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.