-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset handling and refactoring #126
Comments
We have broken out the issues @kadri-nizam raised in the original post into more bite-sized issues. Notes about splitting the imaging and averaging functions of the Topics related to UVDataset are in #162, topics related to GriddedDataset are in #163. It probably makes more sense to try #162 first, since that will help us get a better grasp on the Pytorch dataset idioms. |
Now that #163 and #157 and #154 are implemented, this issue is sufficiently diffuse that I don't think it warrants being open anymore. Issues related to UVDataset are now in #162 whereas issues related to Cross Validation are partially covered in places like #166 , #182 , #133 and #135 (and could probably be redeveloped/condensed). |
Is your feature request related to a problem or opportunity? Please describe.
KFoldCrossValidator
might benefit from inheriting from PyTorch data set where it will be easier to segment the boolean indices as different slices of a PyTorch datasetDescribe the solution you'd like
To stay idiomatic with PyTorch, we can implement a
.to(device)
method that encapsulates the process of transferring the required tensors to the correct device.IC: Let's focus this issue specifically on the (potential) redesign of dataset-focused classes, like
GriddedDataset
orUVDataset
and how inference or cross-validation loops will interact with them. Issue #154 will track progress related to theGridder
and methods to create aGriddedDataset
in the first place.The text was updated successfully, but these errors were encountered: