template based native complex trees #244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilfreddy
reviewed
Aug 8, 2024
ilfreddy
reviewed
Aug 8, 2024
| @@ -185,6 +185,20 @@ void math_utils::apply_filter(double *out, double *in, const MatrixXd &filter, i | |||
| #endif | |||
| } | |||
|
|
|||
| void math_utils::apply_filter(ComplexDouble *out, ComplexDouble *in, const MatrixXd &filter, int kp1, int kp1_dm1, double fac) { | |||
There was a problem hiding this comment.
Could you add a bit of documentation to the new functions you have itroduced?
There was a problem hiding this comment.
will put it in the "FourComponents" PR
ilfreddy
reviewed
Aug 8, 2024
| @@ -122,6 +122,47 @@ template <int D> void testDifferentiationABGV(double a, double b) { | |||
| delete mra; | |||
| } | |||
|
|
|||
| template <int D> void testDifferentiationCplxABGV(double a, double b) { | |||
There was a problem hiding this comment.
Explanation put it in the "FourComponents" PR
ilfreddy
reviewed
Aug 8, 2024
There was a problem hiding this comment.
Seems OK to me but maybe Stig should also have a look.
- Some more documentation would help, at least for the new functions
- The time-evolution part could at this point be rewritten exploiting the native complex number. But I will ask Evgueni :-)
- You should rebase this PR (it should be an easy rebase...)
I cannot pull this branch to my machine to test it (or branch from it)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define trees with a template that can be double (default) or ComplexDouble = std::complex.
The template defines the type of the coefficients.
Under development! (compiles, but not yet fully tested)
Everything is put and updated in the FourComponents PR