Skip to content

Commit

Permalink
fix EP assimp build
Browse files Browse the repository at this point in the history
(still DLLs are in the wrong output dir)

cc: #359
  • Loading branch information
jlblancoc committed Aug 11, 2017
1 parent c9c872e commit 78eb71e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
7 changes: 6 additions & 1 deletion cmakemodules/script_assimp.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ IF (NOT ASSIMP_FOUND)
-DRUNTIME_OUTPUT_DIRECTORY=${MRPT_BINARY_DIR}/bin
INSTALL_COMMAND ""
TEST_COMMAND ""
# PATCH_COMMAND
# ${CMAKE_COMMAND} -E copy "${CMAKE_CURRENT_SOURCE_DIR}/thirdparty/lua/CMakeLists.txt" <SOURCE_DIR>/CMakeLists.txt
)

# ExternalProject_Add_Step(
Expand Down Expand Up @@ -83,7 +85,10 @@ IF (ASSIMP_FOUND_VIA_CMAKE)
LIST(APPEND ASSIMP_LIBRARIES optimized "assimp-mrpt" debug "assimp-mrptd")

# override wrong include dirs:
SET(ASSIMP_INCLUDE_DIRS "${MRPT_SOURCE_DIR}/otherlibs/assimp/include/")
SET(ASSIMP_INCLUDE_DIRS
"${MRPT_SOURCE_DIR}/otherlibs/assimp/include/"
"${MRPT_BINARY_DIR}/assimp-prefix/src/assimp-build/include/"
)

ENDIF (ASSIMP_FOUND_VIA_CMAKE)

Expand Down
4 changes: 2 additions & 2 deletions libs/opengl/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ IF (CMAKE_MRPT_HAS_ASSIMP)
IF (NOT ${ASSIMP_CXX_FLAGS} STREQUAL "")
ADD_DEFINITIONS("${ASSIMP_CXX_FLAGS}")
ENDIF()
IF (NOT ${ASSIMP_INCLUDE_DIRS} STREQUAL "")
IF (NOT "${ASSIMP_INCLUDE_DIRS}" STREQUAL "")
INCLUDE_DIRECTORIES("${ASSIMP_INCLUDE_DIRS}")
ENDIF()
IF(NOT ${ASSIMP_VERSION} STREQUAL "")
IF(NOT "${ASSIMP_VERSION}" STREQUAL "")
string(SUBSTRING "${ASSIMP_VERSION}" 0 1 MRPT_ASSIMP_VERSION_MAJOR)
ADD_DEFINITIONS(-DMRPT_ASSIMP_VERSION_MAJOR=${MRPT_ASSIMP_VERSION_MAJOR})
ENDIF()
Expand Down

0 comments on commit 78eb71e

Please sign in to comment.