Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely remove stlplus #461

Merged
merged 1 commit into from
Mar 1, 2017
Merged

Conversation

jolting
Copy link
Member

@jolting jolting commented Mar 1, 2017

I acknowledge to have:

(Notify: @MRPT/owners )

@jlblancoc
Copy link
Member

I love this one, thanks!! 👍

Being thinking a lot on this recently... we should also add definitions for FooConstPtr in addition to FooPtr, like in PCL, don't you agree?

I also thought (but hasn't tested it yet) that perhaps we could do (via the DECLARE_XXX_POST() macros)

    using FooConstPtr Foo::ConstPtr;
    using FooPtr Foo::Ptr;

and declare the inner types ::Ptr and ::ConstPtr, with those above for keeping backwards compatibility.

Just some ideas without too much thinking.... it may be impossible to do if we need to forward declare them, though...

@jlblancoc jlblancoc merged commit e5cc358 into MRPT:mrpt-2.0-devel Mar 1, 2017
@jlblancoc jlblancoc mentioned this pull request Mar 1, 2017
31 tasks
@jolting
Copy link
Member Author

jolting commented Mar 1, 2017

Personally, I find it difficult to generalize a class when the way it's allocated is so integral to its definition.

Of course using or typedefs within a class doesn't really increase the complexity much, so I'm for the FooConstPtr and FooPtr convention.

I'm under the impression that the DECLARE_XXX_* macros could be replaced by either a couple of using statement with and a templated class. Still thinking about the details though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants