Use CMake >=3.1 ExternalProjects for: assimp, octomap, and Eigen #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
, and use CMake to download it if needed
(still DLLs are in the wrong output dir) cc: #359
jlblancoc
added a commit
that referenced
this pull request
Aug 16, 2017
* Remove embedded copy of assimp, and use CMake to download it if needed * fix EP assimp build (still DLLs are in the wrong output dir) cc: #359 * fix EP assimp link * correctly removed Eigen3 embedded dir * EP out-of-source dirs * done porting eigen & assimp as EP * Remove embedded version of octomap cc: #574 * Add simpler build instructions to README * fix build of EP in GNU/Linux * Debian pkg: update after removing octomap sources
jlblancoc
added a commit
that referenced
this pull request
Aug 16, 2017
* Remove embedded copy of assimp, and use CMake to download it if needed * fix EP assimp build (still DLLs are in the wrong output dir) cc: #359 * fix EP assimp link * correctly removed Eigen3 embedded dir * EP out-of-source dirs * done porting eigen & assimp as EP * Remove embedded version of octomap cc: #574 * Add simpler build instructions to README * fix build of EP in GNU/Linux * Debian pkg: update after removing octomap sources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need to carry embedded copies of those projects within MRPT. System libraries will be used if present; otherwise, they will be downloaded and built automatically as part of the regular build process.