Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggest edit sub section per status type #629

Merged
merged 4 commits into from
Sep 7, 2018
Merged

Conversation

qclin
Copy link
Contributor

@qclin qclin commented Aug 30, 2018

list of sub sections for edit per status type

Questions for some missing fields @matthewberryman @LucieGueuning

  1. Exploration > Resources > Number of people send for explo + function == Expatriate?
  2. Figure > Health and vaccination requirements ? missing
  3. Ongoing > Response > Project code ? what is that ?

@qclin qclin requested a review from mehrdadgit August 30, 2018 13:55
@LucieGueuning
Copy link

LucieGueuning commented Aug 30, 2018 via email

@qclin
Copy link
Contributor Author

qclin commented Sep 1, 2018

@matthewberryman @LucieGueuning the recent two commits address the immediate needs of active users

1de3bfd for Fiona

4da54f8 to address Meak's (of field) confusion over Report > New button as a way to input new notifications

@LucieGueuning
Copy link

Did you consider the bug of Fiona (not only severity scale) with the area that the system is not suggesting.
e.g. Cheng Chau (not being located in New Territories in Hong Kong).

@matthewberryman
Copy link
Contributor

I'd like to get this in soon as @qclin has some fixes in this that address some severity slider issues, but I'm not sure on what you mean @LucieGueuning on Cheng Chau issue? Just noting per https://en.wikipedia.org/wiki/Cheung_Chau and https://en.wikipedia.org/wiki/Hong_Kong#Administrative_divisions that Cheng Chau is indeed part of the New Territories.

@qclin
Copy link
Contributor Author

qclin commented Sep 5, 2018

@matthewberryman Fiona wanted the area to be the one she entered (Cheng Chau) and not the Administrative division suggestion. Which I think we need to think if we need this level distinction, or simply store the name after validation. should create another issue on this topic. of what zoom level to save areas

@matthewberryman matthewberryman merged commit fe3782b into dev Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants