-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1877 [BO - Signalements] Clotures Finistere #1915
1877 [BO - Signalements] Clotures Finistere #1915
Conversation
nb_occupants_logement: 3 | ||
situation_occupant: "1" | ||
territory: "Finistère" | ||
is_imported: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@numew Pour te donner une explication rationnelle :-) Tu n'as pas eu à modifier les fixtures car tes signalements sont importés avec le is_imported = true
A mon avis ça doit être ça
migrations/Version20231107132016.php
Outdated
{ | ||
use ContainerAwareTrait; | ||
|
||
public const SUIVI_DESCRIPTION = 'En cas de besoin concernant votre dossier, merci de vous rapprocher de l\'Adil 29 : 02.98.46.37.38. ou par mail : lhi29@adil29.org'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
y'a un point en trop après le téléphone
Sinon pour le message, je mettrais ceci
En cas de besoin concernant votre dossier, merci de vous rapprocher de l'Adil 29 au 02.98.46.37.38 ou par mail à l'adresse suivante : lhi29@adil29.org.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok c'est corrigé
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ça fonctionne bien, mais je ne comprends pas pourquoi on met un suivi interne avec un texte qui semble s'adresser à l'usager...
Effectivement, @numew faudrait passer le suivi en public seulement (cad toujours pas d'envoi de mail) |
migrations/Version20231107132016.php
Outdated
'createdById' => $user['id'], | ||
'createdAt' => (new \DateTimeImmutable())->format('Y-m-d H:i:s'), | ||
'description' => self::SUIVI_DESCRIPTION, | ||
'isPublic' => 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Au vu du message comme dit @hmeneuvrier , il faudrait mettre le isPublic à true @numew
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est fait
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relecture et retest OK
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Ticket
#1877
Description
Migrations permettant de fermer les tickets du Finistère en statut Nouveau, Actif, En cours hors ceux de Quimper et Brest
Changements apportés
Pré-requis
Tests