[Nouveau formulaire][Accessibilité] L'élément label n'est pas associé au champ #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmeneuvrier
commented
Jan 29, 2024
| @@ -1,6 +1,6 @@ | |||
| <template> | |||
| <div :class="[ customCss, 'signalement-form-roomlist' ]" :id="id"> | |||
| <label class="fr-label" :for="id">{{ label }}</label> | |||
| <label class="fr-label" :for="idPieceAVivre+'_check'">{{ label }}</label> | |||
There was a problem hiding this comment.
Je ne suis pas convaincue par ce choix car la checkbox piece à vivre peut être cachée si l'usager a dit précédemment qu'il n'avait pas de pièce à vivre. Mais c'est la même chose pour cuisine et salle de bain...
Si vous avez une meilleure idée, je suis preneuse
hmeneuvrier
commented
Jan 29, 2024
| @@ -261,7 +261,7 @@ desordre_precision: | |||
| is_danger: 1 | |||
| label: "Mur porteur fissuré : ne sait pas" | |||
| qualification: ['NON_DECENCE', 'RSD', 'MISE_EN_SECURITE_PERIL'] | |||
| desordre_precision_slug: "desordres_batiment_securite_murs_fissures_details_mur_porteur_non" | |||
| desordre_precision_slug: "desordres_batiment_securite_murs_fissures_details_mur_porteur_nsp" | |||
There was a problem hiding this comment.
Rien à voir avec la PR, mais je m'en suis aperçue en testant donc autant corriger
hmeneuvrier
deleted the
bugfix/2101-nouveau-formulaire-accessibilite-label
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#2101
Description
Correction des labels des éléments de formulaires
Changements apportés
Pré-requis
Tests