Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] Nettoyer les migrations après la prochaine MEP #2551

Merged
merged 2 commits into from
May 13, 2024
Merged

[QA] Nettoyer les migrations après la prochaine MEP #2551

merged 2 commits into from
May 13, 2024

Conversation

sfinx13
Copy link
Collaborator

@sfinx13 sfinx13 commented May 10, 2024 •
edited
Loading

Ticket

#2482

Description

Description de la modification apportée

Changements apportés

  • Suppression des migrations fichiers et base de données
  • Re-génération d'une nouvelle première migration
  • Ouverture Drôme
  • Filtrage des territoires dans les fixtures de communes
  • Alignement de la version MySQL local avec celle de scalingo 8.0.35
  • Mise à jour des tests

Pré-requis

make  build

Tests

  • Exécuter make create-db et vérifier qu'il y'ai pas d'erreur
  • Exécuter make create-db-test et vérifier qu'il y'ai pas d'erreur
  • Récupérer la base de prod et executer make load-data et vérifier qu'il y'ai pas d'erreur et que la table doctrine_migration_versions possède 2 enregistrements

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

emilschn
emilschn approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK lecture et tests

hmeneuvrier
hmeneuvrier approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test et relecture OK

@hmeneuvrier hmeneuvrier merged commit 1ee6325 into main May 13, 2024
3 checks passed
@hmeneuvrier hmeneuvrier deleted the feature/2482-clean-migrations branch June 11, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmeneuvrier hmeneuvrier hmeneuvrier approved these changes

@emilschn emilschn emilschn approved these changes

@numew numew Awaiting requested review from numew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfinx13 @emilschn @hmeneuvrier