[FO - Formulaire - Accessibilité - 9.X] Vérifier structure du document #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmeneuvrier
changed the title
emilschn
reviewed
May 30, 2024
assets/vue/components/signalement-form/components/SignalementFormBreadCrumbs.vue
Outdated
Show resolved
Hide resolved
emilschn
reviewed
May 30, 2024
emilschn
reviewed
May 30, 2024
hmeneuvrier
force-pushed
the
feature/2544-fo-formulaire-accessibilite-9x-structure-document
branch
from
e88bd99
to
9640268
Compare
numew
reviewed
May 30, 2024
There was a problem hiding this comment.
Quelques remarques :
Je pense que le texte de la partie adresse et coordonnées devrait être une liste
On pourrait ajouter les roles list et listitem pour les bloc de sélection de désordres
Ce n'est que mon avis mais l'espacement au dessus des titre principaux devrait être réduit (il était déjà assez élevé, et il a encore grandi)
hmeneuvrier
force-pushed
the
feature/2544-fo-formulaire-accessibilite-9x-structure-document
branch
from
9640268
to
1f4b38e
Compare
|
hmeneuvrier
deleted the
feature/2544-fo-formulaire-accessibilite-9x-structure-document
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#2544
Description
[Critère 9.1] : Dans chaque page web, l'information est-elle structurée par l'utilisation appropriée de titres ? ---> hiérarchie de titres revue
[Critère 9.2]: Dans chaque page web, la structure du document est-elle cohérente (hors cas particuliers) ? ---> balise main ajoutée
[Critère 9.3]: Dans chaque page web, chaque liste est-elle correctement structurée ? ---> RAS toutes les listes sont bien structurées
Changements apportés
Pré-requis
npm run buildPour utiliser https://xi.github.io/a11y-outline/ il faut commenter la variable d'env SECURITY_CSP_HEADER_VALUE
On peut aussi utiliser l'extension Axe DevTools (ou un équivalent)
Tests