Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech] Réorganisation de l'injection des variables d'environnement #1447

Merged
merged 23 commits into from
Jul 5, 2024

Conversation

thoomasbro
Copy link
Collaborator

@thoomasbro thoomasbro commented Jun 12, 2024

Related Pull Requests & Issues


  • Tests E2E (Cypress)

Copy link

gitguardian bot commented Jun 12, 2024

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9429425 Triggered Generic Password b10d6d8 docker-compose.yml View secret
9429425 Triggered Generic Password 403ee6f .env.dev.defaults View secret
9429425 Triggered Generic Password da51390 .env.dev.defaults View secret
9429425 Triggered Generic Password 403ee6f infra/configurations/backend/application-dev.properties View secret
9429425 Triggered Generic Password 403ee6f infra/.env.example View secret
9429425 Triggered Generic Password 403ee6f docker-compose.yml View secret
9429425 Triggered Generic Password da51390 docker-compose.yml View secret
9429425 Triggered Generic Password c1a0e69 docker-compose.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@thoomasbro thoomasbro force-pushed the thomas/env-variables branch 3 times, most recently from ce8b205 to fd06ccc Compare June 18, 2024 18:31
@claire2212 claire2212 merged commit e36ea58 into thomas/ajout-cerbere Jul 5, 2024
21 of 22 checks passed
@claire2212 claire2212 deleted the thomas/env-variables branch July 5, 2024 15:10
@claire2212 claire2212 mentioned this pull request Jul 9, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants