Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAPPORT NAV] Nouveau champ observationsByUnit sur le patch des actions env #1475

Conversation

maximeperraultdev
Copy link
Collaborator

Related Pull Requests & Issues


  • Tests E2E (Cypress)

@maximeperraultdev maximeperraultdev changed the title Maxime/feat/1378/add observations by units to patch envaction [RAPPORT NAV] Nouveau champ observationsByUnit sur le patch des actions env Jun 20, 2024
@maximeperraultdev maximeperraultdev changed the base branch from main to maxime/feat/1378/endpoint_edition_action June 27, 2024 07:36
@@ -30,6 +30,7 @@ data class EnvActionControlDataOutput(
val isSafetyEquipmentAndStandardsComplianceControl: Boolean? = null,
val isSeafarersControl: Boolean? = null,
val observations: String? = null,
override val observationsByUnit: String?,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je suis pas sûre que ce soit utile de le mettre dans l'output du bff, on en a pas besoin sur Env

@maximeperraultdev maximeperraultdev force-pushed the maxime/feat/1378/endpoint_edition_action branch 2 times, most recently from b4d9486 to f8dc70b Compare June 27, 2024 16:55
@maximeperraultdev maximeperraultdev changed the base branch from maxime/feat/1378/endpoint_edition_action to main June 27, 2024 17:42
@maximeperraultdev maximeperraultdev force-pushed the maxime/feat/1378/add_observationsByUnits_to_patch_envaction branch from f58fb9f to 7e86670 Compare July 1, 2024 08:36
@maximeperraultdev maximeperraultdev force-pushed the maxime/feat/1378/add_observationsByUnits_to_patch_envaction branch from 7e86670 to 13e2549 Compare July 1, 2024 13:32
@maximeperraultdev maximeperraultdev merged commit e82ccea into main Jul 1, 2024
22 checks passed
@maximeperraultdev maximeperraultdev deleted the maxime/feat/1378/add_observationsByUnits_to_patch_envaction branch July 1, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

public-api pour RapportNav - ajout d'un endpoint pour éditer une Action
3 participants