-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAPPORT NAV] Nouveau champ observationsByUnit sur le patch des actions env #1475
Merged
maximeperraultdev
merged 8 commits into
main
from
maxime/feat/1378/add_observationsByUnits_to_patch_envaction
Jul 1, 2024
Merged
[RAPPORT NAV] Nouveau champ observationsByUnit sur le patch des actions env #1475
maximeperraultdev
merged 8 commits into
main
from
maxime/feat/1378/add_observationsByUnits_to_patch_envaction
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximeperraultdev
changed the title
Maxime/feat/1378/add observations by units to patch envaction
[RAPPORT NAV] Nouveau champ observationsByUnit sur le patch des actions env
Jun 20, 2024
maximeperraultdev
changed the base branch from
main
to
maxime/feat/1378/endpoint_edition_action
June 27, 2024 07:36
claire2212
reviewed
Jun 27, 2024
@@ -30,6 +30,7 @@ data class EnvActionControlDataOutput( | |||
val isSafetyEquipmentAndStandardsComplianceControl: Boolean? = null, | |||
val isSeafarersControl: Boolean? = null, | |||
val observations: String? = null, | |||
override val observationsByUnit: String?, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je suis pas sûre que ce soit utile de le mettre dans l'output du bff, on en a pas besoin sur Env
claire2212
approved these changes
Jun 27, 2024
maximeperraultdev
force-pushed
the
maxime/feat/1378/endpoint_edition_action
branch
2 times, most recently
from
June 27, 2024 16:55
b4d9486
to
f8dc70b
Compare
maximeperraultdev
changed the base branch from
maxime/feat/1378/endpoint_edition_action
to
main
June 27, 2024 17:42
maximeperraultdev
force-pushed
the
maxime/feat/1378/add_observationsByUnits_to_patch_envaction
branch
from
July 1, 2024 08:36
f58fb9f
to
7e86670
Compare
maximeperraultdev
force-pushed
the
maxime/feat/1378/add_observationsByUnits_to_patch_envaction
branch
from
July 1, 2024 13:32
7e86670
to
13e2549
Compare
maximeperraultdev
deleted the
maxime/feat/1378/add_observationsByUnits_to_patch_envaction
branch
July 1, 2024 14:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Pull Requests & Issues