[Zone de vigilance] Pouvoir filtrer les zones de vigilance par période #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximeperraultdev
requested changes
Aug 1, 2024
frontend/cypress/e2e/main_window/layerTree/vigilance_area_layers.spec.ts
Outdated
Show resolved
Hide resolved
frontend/cypress/e2e/main_window/layerTree/vigilance_area_layers.spec.ts
Outdated
Show resolved
Hide resolved
frontend/cypress/e2e/main_window/vigilance_area/create_vigilance_area.spec.ts
Outdated
Show resolved
Hide resolved
frontend/src/features/VigilanceArea/useCases/saveVigilanceArea.ts
Outdated
Show resolved
Hide resolved
| VigilanceArea.VigilanceAreaFilterPeriod.NEXT_THREE_MONTHS, | ||
| undefined | ||
| ) | ||
| expect(result).toEqual([areas[0], areas[1], areas[2]]) |
There was a problem hiding this comment.
suggestion: avoir des assertions un peu plus différents dans les tests
There was a problem hiding this comment.
les assertions des 3 derniers tests sont les mêmes. Je pense que ca vaut le coup de mettre des valeurs plus différentes
frontend/src/features/layersSelector/utils/getFilteredVigilanceAreasPerPeriod.ts
Outdated
Show resolved
Hide resolved
frontend/src/features/layersSelector/utils/getFilteredVigilanceAreasPerPeriod.ts
Show resolved
Hide resolved
frontend/src/features/layersSelector/utils/getFilteredVigilanceAreasPerPeriod.ts
Outdated
Show resolved
Hide resolved
frontend/src/features/layersSelector/utils/getFilteredVigilanceAreasPerPeriod.ts
Outdated
Show resolved
Hide resolved
maximeperraultdev
approved these changes
Aug 1, 2024
maximeperraultdev
approved these changes
Aug 1, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Pull Requests & Issues