-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cant construct a Wiki object without api calls #28
Comments
No. A lot of programs depend on automatic login. You can initialize the wiki without the need for login by leaving the fields blank. Changing this will break a lot of bots including my own. |
The solution is to check for login and login if needed when the Wiki class
|
I think I see what you mean, but I'm so tired and I have another shift in 8 hours. Can we do this tomorrow? |
You should be asleep already. |
I have just headed home ;p
|
Heh. |
The other way to make the Wiki object testable would be to inject the HTTP object |
Can you show me what you want to implement? |
@addshore did we ever fix these when implementing Travis? |
You should be able to construct an object without it actually doing anything too much!
Currently when constructing a Wiki object multiple api calls take place!
These should be put somewhere else, for example in a login function and should be called after construction!
This way we can actually construct a Wiki object for basic testing!
The text was updated successfully, but these errors were encountered: