Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cant construct a Wiki object without api calls #28

Open
addshore opened this issue Feb 1, 2014 · 9 comments
Open

cant construct a Wiki object without api calls #28

addshore opened this issue Feb 1, 2014 · 9 comments

Comments

@addshore
Copy link
Contributor

addshore commented Feb 1, 2014

You should be able to construct an object without it actually doing anything too much!
Currently when constructing a Wiki object multiple api calls take place!
These should be put somewhere else, for example in a login function and should be called after construction!
This way we can actually construct a Wiki object for basic testing!

@cyberpower678
Copy link
Contributor

No. A lot of programs depend on automatic login. You can initialize the wiki without the need for login by leaving the fields blank. Changing this will break a lot of bots including my own.

@addshore
Copy link
Contributor Author

addshore commented Feb 1, 2014

The solution is to check for login and login if needed when the Wiki class
makes calls that need to be logged in.
A change such as this should not break any bots that use the framework or
class
On 1 Feb 2014 04:09, "cyberpower678" notifications@github.com wrote:

No. A lot of programs depend on automatic login. You can initialize the
wiki without the need for login by leaving the fields blank. Changing this
will break a lot of bots including my own.

Reply to this email directly or view it on GitHubhttps://github.com//issues/28#issuecomment-33862040
.

@cyberpower678
Copy link
Contributor

I think I see what you mean, but I'm so tired and I have another shift in 8 hours. Can we do this tomorrow?

@cyberpower678
Copy link
Contributor

You should be asleep already.

@addshore
Copy link
Contributor Author

addshore commented Feb 1, 2014

I have just headed home ;p
On 1 Feb 2014 04:35, "cyberpower678" notifications@github.com wrote:

You should be asleep already.

Reply to this email directly or view it on GitHubhttps://github.com//issues/28#issuecomment-33862473
.

@cyberpower678
Copy link
Contributor

Heh.

@addshore
Copy link
Contributor Author

addshore commented Feb 1, 2014

The other way to make the Wiki object testable would be to inject the HTTP object

@cyberpower678
Copy link
Contributor

Can you show me what you want to implement?

@cyberpower678
Copy link
Contributor

@addshore did we ever fix these when implementing Travis?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants