Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPM install issue #12

Merged
merged 2 commits into from
May 19, 2021
Merged

Fix SPM install issue #12

merged 2 commits into from
May 19, 2021

Conversation

DenTelezhkin
Copy link
Member

It turns out, that if you install library from branch using SPM, SWIFT_PACKAGE is defined for public headers, however if you install from tag(1.0.2 for example), SWIFT_PACKAGE is not defined for public headers, breaking compilation.

<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "<redacted>/SourcePackages/checkouts/FMPFeedbackForm/FMPFeedbackForm/include/FMPFeedbackForm.h"

<redacted>/SourcePackages/checkouts/FMPFeedbackForm/FMPFeedbackForm/include/FMPFeedbackForm.h:16:9: error: 'FMPFeedbackForm/FMPFeedbackParameter.h' file not found
#import <FMPFeedbackForm/FMPFeedbackParameter.h>

To work around this limitation, I created separate FMPFeedbackForm.h file in include folder that uses quoted imports, and removed previous if from framework header, that uses angled imports.

Some useful links:

@PaulTaykalo PaulTaykalo self-requested a review May 19, 2021 13:46
@anton-barkov anton-barkov merged commit 2288754 into MacPaw:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants