TIMOB-9369: BlackBerry: merge BB fork with appcelerator branch #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tates to children
[TIMOB-9016]Clearing text on tableview searchbar causing rendering issues.
…ke rotate animations and like iOS
[MOD-747][MOD-749][MOD-750] Android push notification's badge, sound, vi...
…e into timob-9084
[MOD-752] Fix for data parameters not being URI encoded properly in some...
[TIMOB-7773]iOS: Back/close animation broken when a NavigationGroup is in a TabGroup
TIDOC-353 APIDOC UI.Clipboard rewrite
…e into timob-9427
TIDOC-623 TIDOC-622 APIDOC: Ti.UI.TableViewSection issues
[TIMOB-8955] Set gradient page context as execution context only if available.
timob-9427: implementation of removePerson() + removing support for contacts API 4
TIMOB-9336 Android: If java location for Windows is determined by builder.py, go ...
…ser location can be displayed on maps.
[TIMOB-3215]Make the topmost Parent ScrollView handle the keyboardevents
TIMOB 8091 Android: fix "repeat" animation property
[TIMOB-8471]iOS: VideoPlayer doesnot play with local file on iOS5 and above.
[TIDOC-663][TIMOB-9438][TIMOB-9439] Make the zoom properties play nice with each other
TIMOB-8561 Add Geo permissions when Map.createView is seen, so that user...
Conflicts: apidoc/Titanium/UI/Label.yml apidoc/Titanium/UI/OptionDialog.yml apidoc/Titanium/UI/Switch.yml apidoc/Titanium/UI/TableView.yml apidoc/Titanium/UI/TextField.yml apidoc/Titanium/UI/UI.yml support/project.py
|
caught running validate.py in apidoc |
|
It would be worthwhile to add platforms line to all new entries in the apidoc, as it is not going to have been implemented for BB. This only affects the components that are already partly implemented on BB |
- if blackberry:
+ blackberry_resources = os.path.join(resources_dir, 'blackberry')
+ if blackberry and (not update_platforms or not os.path.exists(blackberry_resources)):
+ if not os.path.exists(blackberry_resources):
+ os.makedirs(blackberry_resources)
blackberry_gen = os.path.join(template_dir,'blackberry','blackberry.py')
- run([sys.executable, blackberry_gen, '--name', name, '--id', appid, '--dir', directory, '--ndk', blac
-we didn't create the resources folder before, i see no reason why we should now. Actually from what i remember (unless it's been changed since), that dir would get deleted in the blackberry.py script before being copied from somewhere else. So creating it here was useless and still is. |
|
Reviewed |
[Changes] ActivityIndicator.yml - fixed BlackBerry spelling - fixed placement of extends TableView.yml - fixed BlackBerry spelling - event swipe - put platforms back TextField.yml - property enableReturnKey - added platforms UI.yml - properties INPUT_BORDERSTYLE_BEZEL, INPUT_BORDERSTYLE_LINE, INPUT_BORDERSTYLE_NONE, INPUT_BORDERSTYLE_ROUNDED - added platforms project.py - reverted extra resource folder creation [Tests] Test 1: validate apidoc 1) Run validate.py 2) Verify there are no errors
|
I've addressed all comments and updated the patch |
|
Looks good to me, Approved |
|
Need merge. Approved |
Conflicts: apidoc/Titanium/UI/ActivityIndicator.yml
dlifshitz-maca
added a commit
that referenced
this pull request
Jun 19, 2012
TIMOB-9369: BlackBerry: merge BB fork with appcelerator branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: Alex, JP
Conflicts:
apidoc/Titanium/UI/Label.yml
apidoc/Titanium/UI/OptionDialog.yml
apidoc/Titanium/UI/Switch.yml
apidoc/Titanium/UI/TableView.yml
apidoc/Titanium/UI/TextField.yml
apidoc/Titanium/UI/UI.yml
support/project.py
Tests: