Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convince mpsolve authors to provide the version number to the program #1175

Closed
DanGrayson opened this issue May 19, 2020 · 7 comments
Closed
Assignees
Milestone

Comments

@DanGrayson
Copy link
Member

... so we can fix this line in d/version.dd:

   "mpsolve version" => "3.1.8", -- TODO: DETERMINE VERSION #??

, which hardcodes the version as 3.1.8.

@DanGrayson
Copy link
Member Author

I've written to the authors requesting the feature.

@d-torrance
Copy link
Member

If the command-line tool is available during build, then we could get it that way:

profzoom@gloria:~/tmp/mpsolve/usr/bin$ ./mpsolve -v | sed 's/MPSolve //'
3.1.8

@DanGrayson
Copy link
Member Author

It is, and we're even distributing it, but it will probably be simpler just to wait for the feature.

@robol
Copy link

robol commented May 21, 2020

We can definitely add that; I opened an issue on MPSolve's repo to track it, I will probably implement it soon.

Also, a slightly unrelated notice: I expect that we may release 3.1.9 with some bugfixes (and likely this change), and later there will be a major version bump because we are in the process of renaming our multiprecision floating point complex type to avoid a name clash with GNU MPC. This will break the API, although anyone not accessing directly multiprecision complex roots won't be affected.

@DanGrayson
Copy link
Member Author

Thanks!

@robol
Copy link

robol commented Jun 12, 2020

I added new functions mps_get_major_version(), mps_get_minor_version(), mps_get_patch_version() are available in the latest release (3.2.1), along with a string representation with mps_get_version().

There are also defines statements included in the main header as follows (for 3.2.1)

#define MPS_MAJOR_VERSION 3
#define MPS_MINOR_VERSION 2
#define MPS_PATCH_VERSION 1

Best, -- Leonardo.

@DanGrayson DanGrayson self-assigned this Jun 12, 2020
@DanGrayson
Copy link
Member Author

Thank you!

@DanGrayson DanGrayson added this to the version 1.16 milestone Jun 12, 2020
@mahrud mahrud mentioned this issue Jun 18, 2020
5 tasks
@DanGrayson DanGrayson modified the milestones: version 1.16, version 1.17 Jul 3, 2020
@mahrud mahrud closed this as completed Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants