Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"intersect" and "intersection" do the same thing #2257

Open
DanGrayson opened this issue Oct 11, 2021 · 2 comments
Open

"intersect" and "intersection" do the same thing #2257

DanGrayson opened this issue Oct 11, 2021 · 2 comments
Assignees

Comments

@DanGrayson
Copy link
Member

Get rid of "intersection", as it is the more recent one.

i1 : apropos "intersect"

o1 = {intersect, intersectInP, intersection}

o1 : List

i2 : help intersect

o2 = intersect -- compute an intersection
     ************************************

     Description
     ===========

     This function calculates the intersection of a list or sequence of compatible objects.

     ...

i3 : help intersection

o3 = intersection -- compute an intersection
     ***************************************

     Description
     ===========

     This function calculates the intersection of a list or sequence of compatible objects.

     ...
@DanGrayson DanGrayson self-assigned this Oct 11, 2021
@mahrud
Copy link
Member

mahrud commented Oct 23, 2021

Why? Some packages have used intersection instead for ages, like Polyhedra:
https://faculty.math.illinois.edu/Macaulay2/doc/Macaulay2-1.17/share/doc/Macaulay2/Polyhedra/html/_intersection.html
And the point of making it shared was to allow different packages to be able to use it, as in #1649.

What should instead be fixed is the documentation, which in v1.18 is hijacked by the shared documentation from Macaulay2Doc:
https://faculty.math.illinois.edu/Macaulay2/doc/Macaulay2/share/doc/Macaulay2/Polyhedra/html/_intersection.html

@DanGrayson
Copy link
Member Author

Well, in order to avoid any disruption, what if we make intersect and intersection (which are in the core) synonyms, the way res and resolution are synonyms? Then it wouldn't matter if you don't remember whether to use the verb or the noun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants