Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FarasaSpellChecker feature to available features. #26

Closed
wants to merge 0 commits into from

Conversation

abdullah-shwaiky
Copy link
Contributor

  • Included JAR file within the source files of the library.
  • Created class called spell_check with the spell checking method.
  • Added a test for the spell checking method in the tests file.

Notes:

  • The spell checking module only works in standalone mode, does not work in interactive mode (stuck).
  • Removed interactive test for Spell Checker from tests.py

@MagedSaeed
Copy link
Owner

Salam @abdullah-shwaiky

Thanks for this PR, and sorry for being late looking at it. Actullay, I am not used to check GitHub notifications.

Actually, you brought a nice idea. Since we are limited by the JARs provided by farasa team, we can add/highlight/document the feature of adding a JAR that is downloaded by the user to the package so that he will have one unified interface for all farasa services. What do you think?

@abdullah-shwaiky
Copy link
Contributor Author

Greetings @MagedSaeed

Thank you for your reply, your efforts in making this repository possible are extremely appreciated.

I tried including one of the JAR files within the code base, but the Github size limit was an issue (and a certain license violation, I suppose?). So if you suggest the user must provide the JAR files, then the solution could be implemented and unified, and I am certainly willing to contribute to it until completion.

My recommendation is contacting the Farasa maintainers and ask them to include the unimplemented services' JAR files within the open-access link included in this module. This way, the JAR files are automatically and officially included in end users' modules, without the hassle of manual inclusion or any license violation from our part. However, their contact email support@farasa.qcri.org seems to have been permanently deleted.

In any case, I closed this pull request because I realized a few more bugs I wanted to fix, and once I re-implement the new services, I'll be more than happy to open a new one.

Looking forward to working with you!

@MagedSaeed
Copy link
Owner

@abdullah-shwaiky , can you take a look into this PR?

#27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants