Bug fix: adding date to the analog clock if showDate is true #3101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## [2.23.0] - 2023-04-04 Thanks to: @angeldeejay, @buxxi, @CarJem, @dariom, @DaveChild, @dWoolridge, @grenagit, @Hirschberger, @KristjanESPERANTO, @MagMar94, @naveensrinivasan, @nfogal, @psieg, @rajniszp, @retroflex, @SkySails and @tomzt. Special thanks to @khassel, @rejas and @sdetweil for taking over most (if not all) of the work on this release as project collaborators. This version would not be there without their effort. Thank you guys! You are awesome! ### Added - Added increments for hourly forecasts in weather module (MagicMirrorOrg#2996) - Added tests for hourly weather forecast - Added possibility to ignore MagicMirror repo in updatenotification module - Added Pirate Weather as new weather provider (MagicMirrorOrg#3005) - Added possibility to use your own templates in Alert module - Added error message if `<modulename>.js` file is missing in module folder to get a hint in the logs (MagicMirrorOrg#2403) - Added possibility to use environment variables in `config.js` (MagicMirrorOrg#1756) - Added option `pastDaysCount` to default calendar module to control of how many days past events should be displayed - Added thai language to alert module - Added option `sendNotifications` in clock module (MagicMirrorOrg#3056) ### Removed - Removed darksky weather provider - Removed unneeded (and unwanted) '.' after the year in calendar repeatingCountTitle (MagicMirrorOrg#2896) ### Updated - Use develop as target branch for dependabot - Update issue template, contributing doc and sample config - The weather modules clearly separates precipitation amount and probability (risk of rain/snow) - This requires all providers that only supports probability to change the config from `showPrecipitationAmount` to `showPrecipitationProbability`. - Update tests for weather and calendar module - Changed updatenotification module for MagicMirror repo only: Send only notifications for `master` if there is a tag on a newer commit - Update dates in Calendar widgets every minute - Cleanup jest coverage for patches - Update `stylelint` dependencies, switch to `stylelint-config-standard` and handle `stylelint` issues, update `main.css` matching new rules - Update Eslint config, add new rule and handle issue - Convert lots of callbacks to async/await - Revise require imports (MagicMirrorOrg#3071 and MagicMirrorOrg#3072) ### Fixed - Fix wrong day labels in envcanada forecast (MagicMirrorOrg#2987) - Fix for missing default class name prefix for customEvents in calendar - Fix electron flashing white screen on startup (MagicMirrorOrg#1919) - Fix weathergov provider hourly forecast (MagicMirrorOrg#3008) - Fix message display with HTML code into alert module (MagicMirrorOrg#2828) - Fix typo in french translation - Yr wind direction is no longer inverted - Fix async node_helper stopping electron start (MagicMirrorOrg#2487) - The wind direction arrow now points in the direction the wind is flowing, not into the wind (MagicMirrorOrg#3019) - Fix precipitation css styles and rounding value - Fix wrong vertical alignment of calendar title column when wrapEvents is true (MagicMirrorOrg#3053) - Fix empty news feed stopping the reload forever - Fix e2e tests (failed after async changes) by running calendar and newsfeed tests last - Lint: Use template literals instead of string concatenation - Fix default alert module to render HTML for title and message - Fix Open-Meteo wind speed units
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #3101 +/- ##
===========================================
+ Coverage 25.61% 25.65% +0.03%
===========================================
Files 53 53
Lines 11421 11426 +5
===========================================
+ Hits 2926 2931 +5
Misses 8495 8495
|
|
Seems this was introduced with #2971 Makes me think if people are using these config options at all, especially the "OBSOLETE" analogShowDate option. So maybe we can clean that option mess a little more? Or maybe do it in a seperate PR and jsut merge this? Also, @jorgenwahlberg can you add a test for the date option with analogclockface? |
cannot be merged because wrong target branch, |
|
Changed target branch to |
@rejas I'm fine with this, now up to you to merge or not ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding date to the clock module when displayType is "analog" and "showDate" is true. The setting in analogShowDate is respected.
Fixes #3100