-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic ksp-1.2 compatibility #9
Open
whale2
wants to merge
1
commit into
MagicSmokeIndustries:develop
Choose a base branch
from
whale2:ksp-1.2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Active struts have a restrictive license from the original creator allowing it only be distributed with Infernal Robotics, but I don't play KSP anymore and don't have much time to maintain neither AS or IR. I can merge your PR, but there are no releases planned, so this change might never see a light of day. |
Uh, it looks to me like no maintainers left and no call for new maintainers
is being issued. That is sad, IR is tremendous mod making KSP twice as
great. Any way to fix it?
…On Mon, Jul 10, 2017 at 9:31 AM, Stepan Andreev ***@***.***> wrote:
Active struts have a restrictive license from the original creator
allowing it only be distributed with Infernal Robotics, but I don't play
KSP anymore and don't have much time to maintain neither AS or IR. I can
merge your PR, but there are no releases planned, so this change might
never see a light of day.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQFuh93tCbwEf51FvnMpS0DOQmjdne5ks5sMdM-gaJpZM4OSRzo>
.
|
IR itself works for 1.2.x and 1.3.x, check the latest releases on Github
On Mon, 10 Jul 2017 at 14:53, Nikita Makeev <notifications@github.com>
wrote:
Uh, it looks to me like no maintainers left and no call for new maintainers
is being issued. That is sad, IR is tremendous mod making KSP twice as
great. Any way to fix it?
On Mon, Jul 10, 2017 at 9:31 AM, Stepan Andreev ***@***.***>
wrote:
> Active struts have a restrictive license from the original creator
> allowing it only be distributed with Infernal Robotics, but I don't play
> KSP anymore and don't have much time to maintain neither AS or IR. I can
> merge your PR, but there are no releases planned, so this change might
> never see a light of day.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <
#9 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/ABQFuh93tCbwEf51FvnMpS0DOQmjdne5ks5sMdM-gaJpZM4OSRzo
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKuLcM5yIvAUhFq3i40hkB3O90d4I2vbks5sMizGgaJpZM4OSRzo>
.
--
Best regards,
Stepan Andreev
|
Oh, I know, thanks, but Active Struts could also be very useful.
On Mon, Jul 10, 2017 at 8:52 PM, Stepan Andreev <notifications@github.com>
wrote:
… IR itself works for 1.2.x and 1.3.x, check the latest releases on Github
On Mon, 10 Jul 2017 at 14:53, Nikita Makeev ***@***.***>
wrote:
> Uh, it looks to me like no maintainers left and no call for new
maintainers
> is being issued. That is sad, IR is tremendous mod making KSP twice as
> great. Any way to fix it?
>
>
> On Mon, Jul 10, 2017 at 9:31 AM, Stepan Andreev <
***@***.***>
> wrote:
>
> > Active struts have a restrictive license from the original creator
> > allowing it only be distributed with Infernal Robotics, but I don't
play
> > KSP anymore and don't have much time to maintain neither AS or IR. I
can
> > merge your PR, but there are no releases planned, so this change might
> > never see a light of day.
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub
> > <
> https://github.com/MagicSmokeIndustries/Active-
Struts/pull/9#issuecomment-314027708
> >,
> > or mute the thread
> > <
> https://github.com/notifications/unsubscribe-auth/
ABQFuh93tCbwEf51FvnMpS0DOQmjdne5ks5sMdM-gaJpZM4OSRzo
> >
> > .
> >
>
> —
> You are receiving this because you commented.
>
>
> Reply to this email directly, view it on GitHub
> <https://github.com/MagicSmokeIndustries/Active-
Struts/pull/9#issuecomment-314112143>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/
AKuLcM5yIvAUhFq3i40hkB3O90d4I2vbks5sMizGgaJpZM4OSRzo>
> .
>
--
Best regards,
Stepan Andreev
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQFut2trz1DO66k66yNVeuUSyKs7wwkks5sMnLZgaJpZM4OSRzo>
.
|
You can compile yourself a version that works, there is no problem with
that.
Also you can try Quantum Struts, a lot of people had success using them as
an alternative.
On Mon, 10 Jul 2017 at 19:56, Nikita Makeev <notifications@github.com>
wrote:
Oh, I know, thanks, but Active Struts could also be very useful.
On Mon, Jul 10, 2017 at 8:52 PM, Stepan Andreev ***@***.***>
wrote:
> IR itself works for 1.2.x and 1.3.x, check the latest releases on Github
>
>
>
> On Mon, 10 Jul 2017 at 14:53, Nikita Makeev ***@***.***>
> wrote:
>
> > Uh, it looks to me like no maintainers left and no call for new
> maintainers
> > is being issued. That is sad, IR is tremendous mod making KSP twice as
> > great. Any way to fix it?
> >
> >
> > On Mon, Jul 10, 2017 at 9:31 AM, Stepan Andreev <
> ***@***.***>
> > wrote:
> >
> > > Active struts have a restrictive license from the original creator
> > > allowing it only be distributed with Infernal Robotics, but I don't
> play
> > > KSP anymore and don't have much time to maintain neither AS or IR. I
> can
> > > merge your PR, but there are no releases planned, so this change
might
> > > never see a light of day.
> > >
> > > —
> > > You are receiving this because you authored the thread.
> > > Reply to this email directly, view it on GitHub
> > > <
> > https://github.com/MagicSmokeIndustries/Active-
> Struts/pull/9#issuecomment-314027708
> > >,
> > > or mute the thread
> > > <
> > https://github.com/notifications/unsubscribe-auth/
> ABQFuh93tCbwEf51FvnMpS0DOQmjdne5ks5sMdM-gaJpZM4OSRzo
> > >
> > > .
> > >
> >
> > —
> > You are receiving this because you commented.
> >
> >
> > Reply to this email directly, view it on GitHub
> > <https://github.com/MagicSmokeIndustries/Active-
> Struts/pull/9#issuecomment-314112143>,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/
> AKuLcM5yIvAUhFq3i40hkB3O90d4I2vbks5sMizGgaJpZM4OSRzo>
> > .
> >
> --
> Best regards,
> Stepan Andreev
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <
#9 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/ABQFut2trz1DO66k66yNVeuUSyKs7wwkks5sMnLZgaJpZM4OSRzo
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKuLcHNwCjkFgIo9w5Rv4FRwR65o-a5_ks5sMnPjgaJpZM4OSRzo>
.
--
Best regards,
Stepan Andreev
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some trivial change due to differences in 1.1 - 1.2 API. Seems working.