Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsWindowDraggable broke starting in 1.2 #2287

Closed
TyBarthel opened this issue Jan 1, 2016 · 11 comments
Closed

IsWindowDraggable broke starting in 1.2 #2287

TyBarthel opened this issue Jan 1, 2016 · 11 comments
Assignees
Labels
Milestone

Comments

@TyBarthel
Copy link

Is this broke in 1.2 or did the behavior change? I don't appear to be able to drag even a basic vanilla window by mouse clicking/dragging on any position except the title bar.

@iskenxan
Copy link

iskenxan commented Jan 2, 2016

I just tested it out and it worked fine for me, if you check IsWindowDraggable property that you mentioned, you will be able to drag and move the window , if you leave it unchecked , you can only resize it.

@Anapher
Copy link
Contributor

Anapher commented Jan 3, 2016

@iskenxan yes, when you drag using the titlebar, but in version 1.1.2 it meant dragging from everywhere (for example if ShowTitleBar is false).

@TyBarthel
Copy link
Author

@alkalinee Yep, exactly. @iskenxan set ShowTitleBar to false and you won't be able to move the window anywhere because the title bar is the only place to grab.

@iskenxan
Copy link

iskenxan commented Jan 6, 2016

@alkalinee Yeah , it only works for title bar , sorry about that

@xiperware
Copy link

Can replicate bug on win 10, create an empty MetroWindow with ShowTitleBar="False", run, can't drag window from anywhere, reverting to older version and it works fine.

@beachwalker
Copy link

Can replicate this, too.

ShowTitleBar="False" and you can't move the window bei drag the Titlebar.
Workaround: Set Title="". I use Style="{DynamicResource CleanWindowStyleKey}".

@TyBarthel TyBarthel changed the title IsWindowDraggable in 1.2 IsWindowDraggable broke starting in 1.2 Jan 18, 2016
@punker76 punker76 added the Bug label Jan 21, 2016
@punker76 punker76 self-assigned this Jan 21, 2016
@punker76 punker76 added this to the 1.2.4 milestone Jan 21, 2016
punker76 added a commit that referenced this issue Jan 21, 2016
@TyBarthel
Copy link
Author

I updated to 1.2.4, but still appear to not be able to drag a window outside of the title bar.

ShowTitleBar="False"
IsWindowDraggable="True"

@punker76
Copy link
Member

@TyBarthel If you have controls in your window which are hittest visible, so there is no chance to drag the window.

@beachwalker
Copy link

works for me now with 1.2.4

@TyBarthel
Copy link
Author

@punker76 I think something else might possibly be going on where something else changed between 1.1.2 and 1.2. While my app is on 1.1.2, I can drag move all over the place. Once I upgrade to 1.2+ (including 1.2.4) I cannot.

I'll do some more investigating when I get a chance and see if I can narrow it down or provide a more concrete example to repro.

@TyBarthel
Copy link
Author

@punker76 I think I see what happened. Prior to 1.2 you used to do drag/move by handling the window's MouseDown event, then in 1.2 you now do it with the PR that uses Thumb. My case might be special, but I essentially have controls (i.e. tabs) all the way to the top of the window (i.e. Edge, Firefox, Chrome, etc.). The old way works because it's based on just mouse down where the new Thumb way doesn't because my controls must be eating those events and is related to IsHitTestVisible.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

6 participants