Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextBoxHelper] ClearTextButton and FloatingWatermark collide when used on NumericUpDown #4015

Closed
DMtsdt opened this issue Jan 5, 2021 · 0 comments · Fixed by #4057
Closed
Assignees
Labels
Milestone

Comments

@DMtsdt
Copy link

DMtsdt commented Jan 5, 2021

Describe the bug

When applied to a NumericUpDown with ButtonsAlignment="Left", and TextBoxHelper.ClearTextButton and TextBoxHelper.UseFloatingWatermark applied - FloatingWatermark appearks on top of ClearTextButton instead of the NumericUpDown's Value.

Steps to reproduce

On a NumericUpDown:

  1. Apply TextBoxHelper.Watermark with any text.
  2. Set TextBoxHelper.UseFloatingWatermark and TextBoxHelper.ClearTextButton to True.
  3. Set ButtonsAlignment to Left.
  4. Type anything in the NumericUpDown.
<mm:NumericUpDown  mm:TextBoxHelper.Watermark="Lorem Ipsum"
                   mm:TextBoxHelper.ClearTextButton="True"
                   mm:TextBoxHelper.UseFloatingWatermark="True"
                   ButtonsAlignment="Left"/>

Expected behavior

FloatingWatermark should appear on top of the NumericUpDown text element.

Actual behavior

FloatingWatermark appears on top of the TextBoxHelper.ClearTextButton instead.

Environment

MahApps.Metro version: v2.4.3
Windows build number: Win10 1903 [Version 10.0.18362.836]
Visual Studio: 2019 16.8.2
Target Framework: .Net v4.6.2

Screenshots

No value:
image

With value:
image

@DMtsdt DMtsdt added the Bug label Jan 5, 2021
@punker76 punker76 self-assigned this Jan 5, 2021
@punker76 punker76 added this to the 2.4.4 milestone Jan 5, 2021
punker76 added a commit that referenced this issue Feb 28, 2021
punker76 added a commit that referenced this issue Feb 28, 2021
Fix FloatingWatermark position when using Left value for TextBoxHelper.ButtonsAlignment
batzen pushed a commit to batzen/MahApps.Metro that referenced this issue Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants