Add 'Remember' CheckBox to the LoginDialog #2308
Conversation
| } | ||
|
|
||
| public class LoginDialogData | ||
| { | ||
| public string Username { get; set; } | ||
| public string Password { get; set; } | ||
| public bool Remember { get; set; } |
There was a problem hiding this comment.
I would change the name of this property to a more boolean-sounding name. I would suggest something like IsRememberRequested, RequestRemember. This is because the developer might be confused because it might understand that MahApps does remember the state of the dialog.
Another possibility would be to add a documentation tag to the property.
There was a problem hiding this comment.
I think ShouldRemember is better since it's a request to the caller to persist the data.
Additionally I'd suggest to make all setters of LoginDialogData internal. There's no need to set these properties outside of MahApps.Metro.
There was a problem hiding this comment.
Yes, I was also thinking about ShouldRemember as alternative to Remember. It is more explicit.
Totally agree on suggested internal improvement.
Made all property setters of LoginDialogData internal.
…e-LoginDialog Add 'Remember' CheckBox to the LoginDialog
…e-LoginDialog Add 'Remember' CheckBox to the LoginDialog (reverted from commit cded951)
This adds a "Remember ..." checkbox to the
LoginDialog. Reference feature #2305.To keep backward compatibility the
CheckboxisCollapsedby default.The default text for
Checkboxequals to "Remember".