Proposal - Dont focus flyout on close

[ButchersBoy]

Background

I have multiple windows, and i'm using flyouts to show an alert condition in the application. When the user dismisses the alert all flyouts are closed via my application code.

The problem

This line causes the last Window my where my code closes the flyout to receive focus , bringing that window to the front, interrupting the users activity:

// focus the Flyout itself to avoid nasty FocusVisual painting (it's visible until the Flyout is closed)        
flyout.Focus();

Remarks

I understand there is a specific comment here regarding this line to perform some visual trickery. However, it's not logically correct. I have experimented, removed the line, and I can't see any display issues in my application.

Maybe someone / @punker76 , with some background on this line can comment?

Another option would be to make the code a bit more specific; only run the focus if the current Window is active, something like:

if (Window.GetWindow(flyout) == Application.Windows.OfType<Window>().FirstOrDefault(w => w.IsActive))
    flyout.Focus();

[punker76]

@ButchersBoy This hack was introduced with #1805 by this issue (found by manual testing)

But now, I can't also not reproduce this with the current source, so I think we can change this.

[ButchersBoy]

Cool! 👍