Hotfix for DateTimePicker/TimePicker #2710

Merged
merged 4 commits into from Oct 24, 2016

Conversation

Projects
None yet
2 participants
@punker76
Member

punker76 commented Oct 23, 2016

  • Binding should now work correctly in both directions
  • [Fix] Issue where clearing text does not immediately set value to ""
  • Add Unit-Test for DateTimePicker
  • [Fix] Issue where Hour 0 is not shown when using 24h clock
  • [Fix] Issue where Binding issues on DateTimePicker/TimePicker are shown on the output window
  • [Fix] Change DateTimePicker.SelectedDate to BindsTwoWayByDefault. The reason is that we do not have to use Mode=TwoWay explicit, and DatePicker.SelectedDate has BindsTwoWayByDefault too.
  • Fix DateTimePickerSetCulture unit test <-- @xxMUROxx
Add changes from @xxMUROxx
  - Binding should now work correctly in both directions
  - [Fix] Issue where clearing text does not immediately set value to ""
  - Add Unit-Test for DateTimePicker
  - [Fix] Issue where Hour 0 is not shown when using 24h clock
  - [Fix] Issue where Binding issues on DateTimePicker/TimePicker are shown on the output window
  - [Fix] Change DateTimePicker.SelectedDate to BindsTwoWayByDefault. The reason is that we do not have to use Mode=TwoWay explicit, and DatePicker.SelectedDate has BindsTwoWayByDefault too.

@punker76 punker76 added this to the 1.4.0 milestone Oct 23, 2016

@punker76 punker76 referenced this pull request Oct 23, 2016

Closed

Hotfix for DateTimePicker/TimePicker #2688

4 of 4 tasks complete

xxMUROxx added a commit to xxMUROxx/MahApps.Metro that referenced this pull request Oct 24, 2016

@punker76 punker76 merged commit 21dfea1 into develop Oct 24, 2016

1 check passed

continuous-integration/teamcity Finished TeamCity Build MahApps.Metro PullRequest :: MahApps.Metro PullRequests : Tests passed: 120
Details

@punker76 punker76 deleted the Hotfix-DateTimePicker-TimePicker branch Oct 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment