Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix for DateTimePicker/TimePicker #2710

Merged
merged 4 commits into from
Oct 24, 2016
Merged

Hotfix for DateTimePicker/TimePicker #2710

merged 4 commits into from
Oct 24, 2016

Conversation

punker76
Copy link
Member

@punker76 punker76 commented Oct 23, 2016 •
edited
Loading

  • Binding should now work correctly in both directions
  • [Fix] Issue where clearing text does not immediately set value to ""
  • Add Unit-Test for DateTimePicker
  • [Fix] Issue where Hour 0 is not shown when using 24h clock
  • [Fix] Issue where Binding issues on DateTimePicker/TimePicker are shown on the output window
  • [Fix] Change DateTimePicker.SelectedDate to BindsTwoWayByDefault. The reason is that we do not have to use Mode=TwoWay explicit, and DatePicker.SelectedDate has BindsTwoWayByDefault too.
  • Fix DateTimePickerSetCulture unit test <-- @xxMUROxx

@punker76
Add changes from @xxMUROxx
952d4d1 
  - Binding should now work correctly in both directions
  - [Fix] Issue where clearing text does not immediately set value to ""
  - Add Unit-Test for DateTimePicker
  - [Fix] Issue where Hour 0 is not shown when using 24h clock
  - [Fix] Issue where Binding issues on DateTimePicker/TimePicker are shown on the output window
  - [Fix] Change DateTimePicker.SelectedDate to BindsTwoWayByDefault. The reason is that we do not have to use Mode=TwoWay explicit, and DatePicker.SelectedDate has BindsTwoWayByDefault too.
@punker76 punker76 added this to the 1.4.0 milestone Oct 23, 2016
@punker76 punker76 mentioned this pull request Oct 23, 2016
Closed
4 tasks
michaelmairegger added a commit to michaelmairegger/MahApps.Metro that referenced this pull request Oct 24, 2016
@michaelmairegger
[Fix] Failing Unit Test in PR MahApps#2710
59d8bd6
@punker76 punker76 merged commit 21dfea1 into develop Oct 24, 2016
@punker76 punker76 deleted the Hotfix-DateTimePicker-TimePicker branch October 24, 2016 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@punker76