New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HamburgerMenu SelectedIndex Fix #2796

Merged
merged 3 commits into from Jan 5, 2017

Conversation

Projects
None yet
2 participants
@punker76
Member

punker76 commented Jan 5, 2017

What changed?

If we set the SelectedIndex on the HamburgerMenu then we get the System.Reflection.TargetInvocationException. This PR fixes this issue and it's now possible to set the SelectedIndex/SelectedItem or the SelectedOptionsIndex/SelectedOptionsItem.
Also added properties to set the ItemTemplateSelector for menu and option items.

punker76 added some commits Jan 4, 2017

Fix TargetInvocationException on HamburgerMenu
  If we set the SelectedIndex on the HamburgerMenu then we get the System.Reflection.TargetInvocationException
  Now it's possible to set the SelectedIndex/SelectedItem or the SelectedOptionsIndex/SelectedOptionsItem

@punker76 punker76 added this to the 1.4.1 milestone Jan 5, 2017

@thoemmi

thoemmi approved these changes Jan 5, 2017 edited

Looks good to me 👍

@punker76 punker76 merged commit d811792 into develop Jan 5, 2017

1 check passed

continuous-integration/teamcity Finished TeamCity Build MahApps.Metro PullRequest :: MahApps.Metro PullRequests : Tests passed: 62
Details

@punker76 punker76 deleted the HamburgerMenu-SelectedIndex-Fix branch Jan 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment