Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HamburgerMenu SelectedIndex Fix #2796

Merged
merged 3 commits into from
Jan 5, 2017
Merged

Conversation

punker76
Copy link
Member

@punker76 punker76 commented Jan 5, 2017

What changed?

If we set the SelectedIndex on the HamburgerMenu then we get the System.Reflection.TargetInvocationException. This PR fixes this issue and it's now possible to set the SelectedIndex/SelectedItem or the SelectedOptionsIndex/SelectedOptionsItem.
Also added properties to set the ItemTemplateSelector for menu and option items.

  If we set the SelectedIndex on the HamburgerMenu then we get the System.Reflection.TargetInvocationException
  Now it's possible to set the SelectedIndex/SelectedItem or the SelectedOptionsIndex/SelectedOptionsItem
@punker76 punker76 added this to the 1.4.1 milestone Jan 5, 2017
Copy link
Collaborator

@thoemmi thoemmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@punker76 punker76 merged commit d811792 into develop Jan 5, 2017
@punker76 punker76 deleted the HamburgerMenu-SelectedIndex-Fix branch January 5, 2017 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants