Screenshot improvements #2326
Labels
feature
Feature requests
javascript
Pull requests that update Javascript code. Usually created by Dependabot.
pr-visualization
Issues that touch the visualization pr(oject) which means web and desktop features.
priority:high
Set by PO
Milestone
Comments
BridgeAR
added
pr-visualization
This was
linked to
pull requests
Aug 30, 2021
ce-bo
pushed a commit
that referenced
this issue
Sep 3, 2021
|
Please be careful about PRs closing issues that they should not :-) // @Shivan-997 @ce-bo |
|
I changed the scope of this issue to only provide the legend in the screenshot output. This is the most important thing to do. |
BenediktMehl
added a commit
that referenced
this issue
Dec 9, 2022
BenediktMehl
added a commit
that referenced
this issue
Dec 9, 2022
BenediktMehl
added a commit
that referenced
this issue
Dec 9, 2022
BenediktMehl
added a commit
that referenced
this issue
Dec 9, 2022
BenediktMehl
added a commit
that referenced
this issue
Dec 9, 2022
BenediktMehl
added a commit
that referenced
this issue
Dec 9, 2022
* chore(deps): update dependency @types/node to v18 * chore(deps): update dependency @types/node to v18 * Migrate to nodev18 * Add: attributeDescriptor TEST to multiple Files (Still one compile error) #1066 * Add: missing reducer statement - no compile error anymore#1066 * Refactor: rename "Size" metric in legendPanel to "Area"#1066 the word "Size" is quite unusual at this position because in the code and in the ribbonbar the word "Area" is used * Refactor: some consoleprints and delete unused variables and methods"#1066 * Refactor: delete "test" node in attributeDescriptors layout#1066 * Add: entry for download feature #1066 * Refactor: move getDescription function to legendMetrics #1066 * Add: implementation for merged attributeDescriptors.merger #1066 * Add: attributeDescriptor to attributeDescriptors settings #1066 * Add: if condition to show description in legend block for every metric type #1066 * Refactor: methods and settings layout to fit new cc.json format #1066 * Fix: test errors #1066 * Add: title for legend blocks in legend #1066 * Fix: remove title from color picker #1066 * Add: case for existing title and missing description #1066 * Refactor: text in legendBlock to be uniform #1066 * Refactor: metricTitles cases to fit to new attribute descriptors #1066 * Fix: failing tests #1066 * Fix: format tests #1066 * Fix: test coverage #1066 * Fix: test coverage error #1066 * Update webpack and tapable * Fix: test coverage error second try #1066 * Refactor: metric name to key #1066 * Fix: refactoring erros #1066 * Chore: Merge main * Chore: Update puppeteer to see if that fixes the pipeline * Chore: remove now unused method from puppeteer helper * Test: change jest testTimeout to 80s #1066 * Fix: PR comments #1066 * Revert "Test: change jest testTimeout to 80s #1066" This reverts commit 48f45f8. I reverted this commit, because it's not the suitable branch for it. * Fix: test error #1066 * TEST Refactor: change "testTimeout": 800000 #2326 * TEST Refactor: waitForFileChooser({ timeout: 800_000 #2326 * TEST Refactor: don't runInBand #2326 * fix: downgrade puppeteer 19 -> 16 again * Revert "TEST Refactor: waitForFileChooser({ timeout: 800_000 #2326" This reverts commit 8ce820e. * Revert "TEST Refactor: don't runInBand #2326" This reverts commit baf77cf. * Revert "TEST Refactor: change "testTimeout": 800000 #2326" This reverts commit 0f5e5d5. * fix: upgrade puppeteer one last time 16 -> 17 * Add: Test for attributeDescriptors.reducer #2326 * Add changelog entry #2326 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: luig59 <luig59@mi.fu-berlin.de> Co-authored-by: MW-Friedrich <108457762+MW-Friedrich@users.noreply.github.com>
BenediktMehl
added a commit
that referenced
this issue
Dec 9, 2022
BenediktMehl
added a commit
that referenced
this issue
Dec 9, 2022
BenediktMehl
added a commit
that referenced
this issue
Dec 9, 2022
BenediktMehl
added a commit
that referenced
this issue
Dec 9, 2022
* chore(deps): update dependency @types/node to v18 * chore(deps): update dependency @types/node to v18 * Migrate to nodev18 * Add: attributeDescriptor TEST to multiple Files (Still one compile error) #1066 * Add: missing reducer statement - no compile error anymore#1066 * Refactor: rename "Size" metric in legendPanel to "Area"#1066 the word "Size" is quite unusual at this position because in the code and in the ribbonbar the word "Area" is used * Refactor: some consoleprints and delete unused variables and methods"#1066 * Refactor: delete "test" node in attributeDescriptors layout#1066 * Add: entry for download feature #1066 * Refactor: move getDescription function to legendMetrics #1066 * Add: implementation for merged attributeDescriptors.merger #1066 * Add: attributeDescriptor to attributeDescriptors settings #1066 * Add: if condition to show description in legend block for every metric type #1066 * Refactor: methods and settings layout to fit new cc.json format #1066 * Fix: test errors #1066 * Add: title for legend blocks in legend #1066 * Fix: remove title from color picker #1066 * Add: case for existing title and missing description #1066 * Refactor: text in legendBlock to be uniform #1066 * Refactor: metricTitles cases to fit to new attribute descriptors #1066 * Fix: failing tests #1066 * Fix: format tests #1066 * Fix: test coverage #1066 * Fix: test coverage error #1066 * Update webpack and tapable * Fix: test coverage error second try #1066 * Refactor: metric name to key #1066 * Fix: refactoring erros #1066 * Chore: Merge main * Chore: Update puppeteer to see if that fixes the pipeline * Chore: remove now unused method from puppeteer helper * Test: change jest testTimeout to 80s #1066 * Fix: PR comments #1066 * Revert "Test: change jest testTimeout to 80s #1066" This reverts commit 48f45f8. I reverted this commit, because it's not the suitable branch for it. * Fix: test error #1066 * TEST Refactor: change "testTimeout": 800000 #2326 * TEST Refactor: waitForFileChooser({ timeout: 800_000 #2326 * TEST Refactor: don't runInBand #2326 * fix: downgrade puppeteer 19 -> 16 again * Revert "TEST Refactor: waitForFileChooser({ timeout: 800_000 #2326" This reverts commit 8ce820e. * Revert "TEST Refactor: don't runInBand #2326" This reverts commit baf77cf. * Revert "TEST Refactor: change "testTimeout": 800000 #2326" This reverts commit 0f5e5d5. * fix: upgrade puppeteer one last time 16 -> 17 * Add: Test for attributeDescriptors.reducer #2326 * Add changelog entry #2326 * Add changelog entry for new tooltips #2326 * Refactor: "alt text" to "image" #2326 * Update CHANGELOG.md Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com> * Refactor: changelog entries #2326 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: luig59 <luig59@mi.fu-berlin.de> Co-authored-by: MW-Friedrich <108457762+MW-Friedrich@users.noreply.github.com> Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
|
Closed as completed. Adding the legend to screenshot will be done in #3080. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature request
Description
As a user, I want to see all parts of the view on my screenshot so that I have the same information on the screenshot as I do when having a open map.
Acceptance criteria
Add a new hotkey to save the screenshot to the clipboard instead of saving it to a file.Add a section in the global configuration to allow changing default screenshot behavior (allowing to switch between different output behaviors - either saving to file or to clipboard)Add a option to add the logo to the screenshot output and use that as new default behavior(a separate issue exists for that part)Add the legend to the screenshot output (will be done in Screenshot Improvements #2 #3080
Development notes (optional Task Breakdown)
Please add one PR per acceptance criteria, building one feature on top of the other.
The text was updated successfully, but these errors were encountered: