Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1066/display tooltip description in frontend #3169

Merged
merged 59 commits into from
Dec 9, 2022
Merged

Feature/1066/display tooltip description in frontend #3169

merged 59 commits into from
Dec 9, 2022

Conversation

BenediktMehl
Copy link
Collaborator

New changelog entry for tooltip description in legend

Issue: #1066

Description

  • Add changelog entry for the changed tooltips in the legend

renovate bot and others added 30 commits November 17, 2022 16:13
@renovate
chore(deps): update dependency @types/node to v18
18d5a1e
@renovate
chore(deps): update dependency @types/node to v18
4e68eb9
Migrate to nodev18
bfda176
Merge branch 'renovate/node-18.x' of github.com:MaibornWolff/codechar…
f3c4adf 
…ta into renovate/node-18.x
@BenediktMehl
Add: attributeDescriptor TEST to multiple Files (Still one compile er…
943b806 
…ror) #1066
@BenediktMehl
Add: missing reducer statement - no compile error anymore#1066
4dace64
@BenediktMehl
Refactor: rename "Size" metric in legendPanel to "Area"#1066
ca783f3 
the word "Size" is quite unusual at this position because in the code and in the ribbonbar the word "Area" is used
@BenediktMehl
Refactor: some consoleprints and delete unused variables and methods"#…
8a98721 
…1066
@BenediktMehl
Refactor: delete "test" node in attributeDescriptors layout#1066
ac1580b
@BenediktMehl
Add: entry for download feature #1066
dbcb3fa
@BenediktMehl
Refactor: move getDescription function to legendMetrics #1066
b58ddd2
@BenediktMehl
Add: implementation for merged attributeDescriptors.merger #1066
ec3d0a5
@BenediktMehl
Add: attributeDescriptor to attributeDescriptors settings #1066
8c31b19
@BenediktMehl
Add: if condition to show description in legend block for every metri…
0512829 
…c type #1066
@BenediktMehl
Refactor: methods and settings layout to fit new cc.json format #1066
c5c0c96
@BenediktMehl
Fix: test errors #1066
f56167f
@BenediktMehl
Add: title for legend blocks in legend #1066
21823bb
@BenediktMehl
Fix: remove title from color picker #1066
fde8889
@BenediktMehl
Add: case for existing title and missing description #1066
aa25ee4
@BenediktMehl
Refactor: text in legendBlock to be uniform #1066
a7d3dbe
@BenediktMehl
Merge branch 'main' into feature/1066/display-tooltip-description-in-…
cc84e0f 
…frontend
@BenediktMehl
Refactor: metricTitles cases to fit to new attribute descriptors #1066
fc4b906
@BenediktMehl
Fix: failing tests #1066
7085c50
@BenediktMehl
Fix: format tests #1066
461c299
@BenediktMehl
Fix: test coverage #1066
59acbe2
@BenediktMehl
Fix: test coverage error #1066
5f484ad
Update webpack and tapable
d0e7169
@BenediktMehl
Fix: test coverage error second try #1066
8f19f4b
@BenediktMehl
Refactor: metric name to key #1066
099eae1
@MW-Friedrich
Merge branch 'main' into renovate/node-18.x
dc8351e 
# Conflicts:
#	visualization/package-lock.json
BenediktMehl and others added 17 commits December 8, 2022 16:27
@BenediktMehl
Revert "Test: change jest testTimeout to 80s #1066"
3cbe2d3 
This reverts commit 48f45f8.
I reverted this commit, because it's not the suitable branch for it.
@BenediktMehl
Fix: test error #1066
8121ef7
@BenediktMehl
TEST Refactor: change "testTimeout": 800000 #2326
0f5e5d5
@BenediktMehl
TEST Refactor: waitForFileChooser({ timeout: 800_000 #2326
8ce820e
@BenediktMehl
TEST Refactor: don't runInBand #2326
baf77cf
@MW-Friedrich
fix: downgrade puppeteer 19 -> 16 again
0b6b477
@BenediktMehl
Revert "TEST Refactor: waitForFileChooser({ timeout: 800_000 #2326"
eb3ffdc 
This reverts commit 8ce820e.
@BenediktMehl
Revert "TEST Refactor: don't runInBand #2326"
345f166 
This reverts commit baf77cf.
@BenediktMehl
Revert "TEST Refactor: change "testTimeout": 800000 #2326"
4cd007a 
This reverts commit 0f5e5d5.
@MW-Friedrich
fix: upgrade puppeteer one last time 16 -> 17
df987b6
@BenediktMehl
Merge branch 'renovate/node-18.x' into feature/1066/display-tooltip-d…
ae29ac8 
…escription-in-frontend
@BenediktMehl
Add: Test for attributeDescriptors.reducer #2326
4e03ad5
@MW-Friedrich
Merge branch 'main' into feature/1066/display-tooltip-description-in-…
188f37e 
…frontend
@BenediktMehl
Merge branch 'main' into feature/1066/display-tooltip-description-in-…
e18d987 
…frontend
@BenediktMehl
Add changelog entry #2326
44491f6
@BenediktMehl
Add changelog entry for new tooltips #2326
3191a1e
@BenediktMehl
Merge branch 'main' into feature/1066/display-tooltip-description-in-…
8a898df 
…frontend
@BenediktMehl BenediktMehl marked this pull request as ready for review December 9, 2022 14:11
ce-bo
ce-bo reviewed Dec 9, 2022
View reviewed changes
CHANGELOG.md Outdated
### Changed

- Metric descriptions are shown via tooltip in the legend [#3162](https://github.com/MaibornWolff/codecharta/pull/3162)
![alt text](https://user-images.githubusercontent.com/27358421/205251507-100b1e1a-d86e-44f3-89cf-f32bf295aabd.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I compare this to other image tags in this changelog, I notice that there is a
missing a line before and other images do not use [alt text] but [image instead]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case you need some help, out contributing.md has an example on how to format images correctly https://github.com/MaibornWolff/codecharta/blob/main/CONTRIBUTING.md#how-should-you-format-a-changelog-entry

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed "alt text" to "image" now.
I haven't seen where the line is missing

ce-bo
ce-bo reviewed Dec 9, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
BenediktMehl and others added 2 commits December 9, 2022 15:53
@BenediktMehl @ce-bo
Update CHANGELOG.md
bce2787 
Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
@BenediktMehl
Refactor: changelog entries #2326
b3c4057
@BenediktMehl BenediktMehl enabled auto-merge (squash) December 9, 2022 15:15
@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@BenediktMehl BenediktMehl merged commit 77f8f15 into main Dec 9, 2022
@BenediktMehl BenediktMehl deleted the feature/1066/display-tooltip-description-in-frontend branch December 9, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MW-Friedrich MW-Friedrich MW-Friedrich left review comments

@ce-bo ce-bo ce-bo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BenediktMehl @ce-bo @MW-Friedrich