Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cssh check command throws exception #2704

Closed
ce-bo opened this issue Mar 7, 2022 · 1 comment
Closed

cssh check command throws exception #2704

ce-bo opened this issue Mar 7, 2022 · 1 comment
Assignees
Labels
bug Only issues that describe bugs. difficulty:low Solving this is likely not that difficult good first issue pr-analysis Issues that touch the analysis pr(oject). priority:high Set by PO won't implement Won't implement in CC, at least for now

Comments

@ce-bo
Copy link
Collaborator

ce-bo commented Mar 7, 2022

Bug

Expected Behavior

WHEN executing ccsh check <path/to/valid/cc.json>

THEN the the ValidationTool should display either that the file is valid or a pretty error message

Actual Behavior

an exception with no concrete validation results is thrown for actually valid cc.json files (e.g. the current codecharta.cc.json file downloaded from Web Demo). I think the JSON Schema which is used for validation is not up to date (analysis/tools/ValidationTool/src/main/resources/cc.json).

Screenshots

image

Specifications

  • is released in online-demo: yes
  • CodeCharta Version: 1.91.0
  • OS: all
@ce-bo ce-bo added bug Only issues that describe bugs. difficulty:low Solving this is likely not that difficult good first issue pr-analysis Issues that touch the analysis pr(oject). labels Mar 7, 2022
@BridgeAR BridgeAR added the priority:high Set by PO label Mar 11, 2022
@Chrisp485 Chrisp485 self-assigned this Jun 2, 2022
@Chrisp485
Copy link
Contributor

The Exception is caused, because after downloading from the visualiazation the format of the cc.json is changed

Screenshot 2022-06-03 155052

In the future, when global configs will be available across the app the download button will be removed.

@BridgeAR BridgeAR added the won't implement Won't implement in CC, at least for now label Jun 3, 2022
shaman-apprentice added a commit that referenced this issue Aug 11, 2022
please not, that downloading and uploading of a map results in a loss of nodes (exact same behaviour as in main). As the download button will be removed in the future, we decided to not spent further time into this. But this is not related to the Angular migration for sure. #2704 might be related.

ref #2318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Only issues that describe bugs. difficulty:low Solving this is likely not that difficult good first issue pr-analysis Issues that touch the analysis pr(oject). priority:high Set by PO won't implement Won't implement in CC, at least for now
Projects
None yet
Development

No branches or pull requests

3 participants