Refactor/2318/migrate download button #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of cc-action-icons ref #2318
knoffi
suggested changes
Aug 11, 2022
| expect(mockedDownload).toHaveBeenCalled() | ||
| expect(mockedDownload.mock.calls[0][0]).toBe(mockedAccumulatedData["unifiedMapNode"]) | ||
| expect(mockedDownload.mock.calls[0][1]).toBe(mockedAccumulatedData["unifiedFileMeta"]) | ||
| expect(mockedDownload.mock.calls[0][3].length).toBe(2) |
There was a problem hiding this comment.
What about the FileSettings in the mock call? I.e., I would have exspected an assertion for the value of the 3rd parameter:
expect(mockedDownload.mock.calls[0][2]).toBe(...)
There was a problem hiding this comment.
it's a plain getter from mocked state. I think mocking it usefully and checking against the mock doesn't provide any further insurance and is therefore not worth the effort
visualization/app/codeCharta/ui/toolBar/downloadButton/downloadButton.component.spec.ts
Show resolved
Hide resolved
visualization/app/codeCharta/ui/toolBar/downloadButton/downloadDialog/util/propertyHelper.ts
Outdated
Show resolved
Hide resolved
visualization/app/codeCharta/ui/toolBar/downloadButton/downloadDialog/util/propertyHelper.ts
Show resolved
Hide resolved
|
I loved the code. It was very smooth to read. |
…dButton.component.spec.ts Co-authored-by: Matthias Möser <46388280+knoffi@users.noreply.github.com>
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!
|
|
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please not, that downloading and uploading of a map results in a loss of nodes (exact same behaviour as in main). As the download button will be removed in the future, we decided to not spent further time into this. But this is not related to the Angular migration for sure. #2704 might be related.