Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI of add custom scenario dialog #2926

Closed
shaman-apprentice opened this issue Aug 2, 2022 · 2 comments · Fixed by #2928
Closed

Improve UI of add custom scenario dialog #2926

shaman-apprentice opened this issue Aug 2, 2022 · 2 comments · Fixed by #2928
Assignees

Comments

@shaman-apprentice
Copy link
Contributor

Feature request

Description

As a user I want to know, why I cannot add a custom scenario.

As a user I want all options, which I cannot influence, not to be present, for having a lean ui, which enabled me to do my work faster.

Acceptance criteria

  • Error message is shown, when scenario name is empty
  • Error message is shown, when no property is selected
  • Edge-Metric is not shown, when there are no edge metrics

Screenshot

image

@BridgeAR
Copy link
Member

BridgeAR commented Aug 3, 2022

We already deactivate out the Add button in case something is wrong. Yes, indicating the name is not there is a nice to have but I would not want time to be invested into implementing this as it does not seem really necessary. An error on not selecting a metric does not seem to be required either, as it does not make sense to do that. I don't think users are actually going to have an issue with that (it does work with the deactivated button).

The edge metric should still be possible to activate, no matter if it's applicable to the current map. Scenarios are meant as a "general" thing and may apply to any map. We could rework that a scenario with edge metrics also applies to maps that do not have any (as it does not hurt to apply it).

@shaman-apprentice
Copy link
Contributor Author

I will create another FR for a more generic selection as discussed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants