Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/2318/migrate add scenari settings #2928

Merged
merged 14 commits into from Aug 3, 2022

Conversation

shaman-apprentice
Copy link
Contributor

@shaman-apprentice shaman-apprentice commented Aug 2, 2022

@shaman-apprentice shaman-apprentice marked this pull request as ready for review August 3, 2022 08:28
Copy link
Contributor

@Chrisp485 Chrisp485 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.9% 94.9% Coverage
0.0% 0.0% Duplication

@shaman-apprentice shaman-apprentice merged commit 9b3c2bf into main Aug 3, 2022
@shaman-apprentice shaman-apprentice deleted the refactor/2318/migrate-add-scenari-settings branch August 3, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom scenarios without edge metric available are not applicable Improve UI of add custom scenario dialog
2 participants