Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loading indicator isn't working #2977

Closed
1 task
shaman-apprentice opened this issue Aug 11, 2022 · 2 comments · Fixed by #2980
Closed
1 task

loading indicator isn't working #2977

shaman-apprentice opened this issue Aug 11, 2022 · 2 comments · Fixed by #2980
Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:medium Set by PO
Milestone
automation-basics-4

Comments

@shaman-apprentice
Copy link
Contributor

shaman-apprentice commented Aug 11, 2022 •
edited

Bug

Expected Behavior

Given a huge map
When I load it
Then a loading indicator is displayed on the map while it is loading

Actual Behavior

The page becomes unresponsive until the map is loading

Screenshots

Steps to Reproduce the Problem

  1. Load a huge map, which needs several seconds to load
  2. Wait until it gets loaded and see that there was no loading indicator

Specifications

  • is released in online-demo: yes
  • CodeCharta Version: 1.103.1

Developer notes

Without checking I assume that:

  • Parsing of file is probably done on main thread, which would block animation of loading give anyway.
  • Rendering is probably done on main thread, which would block animation of loading give anyway.

TODOs

  • Check if we still need isLoadingMap and isLoadingFile within store/appSettings
@shaman-apprentice shaman-apprentice added bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. labels Aug 11, 2022
@ce-bo ce-bo added the priority:high Set by PO label Aug 11, 2022
@shaman-apprentice shaman-apprentice mentioned this issue Aug 11, 2022
Merged
@ce-bo ce-bo added this to the automation-basics-3 milestone Aug 12, 2022
@ce-bo
Copy link
Collaborator

ce-bo commented Aug 12, 2022

This issue is included in our current milestone. Please do a first analysis of the bug and see how much effort it is to fix it. If a lot of effort is needed, I would like to exclude it from the milestone, as it is not a critical bug.

@ce-bo ce-bo added priority:medium Set by PO and removed priority:high Set by PO labels Aug 12, 2022
@shaman-apprentice
Copy link
Contributor Author

With a very quick look, I don't know at which point in time it broke. I am currently migrating / reworking the render process. I recommend to postpone this ticket until then and volunteer to take over it afterwards.

shaman-apprentice added a commit that referenced this issue Sep 14, 2022
@shaman-apprentice
Refactor/2318/migrate pre render service 2 (#2980)
3ee57c9 
- fix loading indicator isn't working #2977
- ref  Migrate all Angular Components and Services #2318 (migrate codeMap.preRender.service)
  - explicit state actions on which to render
  - throttle rendering (reducing total initial calls to render of default dev map from 58 to 1) a very rough performance analysis through chrome's performance profile shows no real difference (uploading a 1.704kb and a 28.596kb file)
- delete code for re-selecting building after map change as this didn't work and wasn't missed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:medium Set by PO
Projects
None yet
Milestone
automation-basics-4
Development

Successfully merging a pull request may close this issue.

Refactor/2318/migrate pre render service 2 MaibornWolff/codecharta
2 participants
@shaman-apprentice @ce-bo