Refactor/2318/migrate pre render service 2 #2980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shaman-apprentice
commented
Aug 11, 2022
•
shaman-apprentice
commented
- fix loading indicator isn't working #2977
- ref Migrate all Angular Components and Services #2318 (migrate codeMap.preRender.service)
- explicit state actions on which to render
- throttle rendering (reducing total initial calls to render of default dev map from 58 to 1)
- a very rough performance analysis through chrome's performance profile shows no real difference (uploading a 1.704kb and a 28.596kb file)
- delete code for re-selecting building after map change as this didn't work and wasn't missed
added 6 commits
August 11, 2022 16:56
…oading indicators ref #2318
1 task
shaman-apprentice
force-pushed
the
refactor/2318/migrate-pre-render-service-2
branch
from
70cf60d
to
ad4b8c3
Compare
|
@shaman-apprentice is it intentional that this is still a draft? I guess so as there are still some open ToDos? |
…-pre-render-service-2
…-pre-render-service-2
…-pre-render-service-2
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!
|
|
[CodeCharta Visualization] SonarCloud Quality Gate failed. |
Hall-Ma
reviewed
Sep 14, 2022
Hall-Ma
reviewed
Sep 14, 2022
visualization/app/codeCharta/state/effects/renderCodeMapEffect/renderCodeMap.effect.ts
Show resolved
Hide resolved
Hall-Ma
approved these changes
Sep 14, 2022
shaman-apprentice
deleted the
refactor/2318/migrate-pre-render-service-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.