Refactor/2734/migrate custom configs list #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: customConfigFileStateConnector doesn't recognize changes when files change ToDo: Implement new selector that returns downloadable custom views, so that fileStateConnector is not necessary anymore #2734
Next step: implement correct type in Map #2734
Note: When custom config menu is clicked several times the new selector is not active because there is no file change #2734
…al storage has changed #2734
…adCustomConfig service #2734
…-download-button-for-custom-configs
...lization/app/codeCharta/ui/customConfigs/customConfigList/customConfigItemGroup.component.ts
Show resolved
Hide resolved
|
[CodeCharta Visualization] SonarCloud Quality Gate failed. |
visualization/app/codeCharta/ui/customConfigs/customConfigList/customConfigList.component.html
Outdated
Show resolved
Hide resolved
visualization/app/codeCharta/ui/customConfigs/customConfigList/customConfigList.component.scss
Outdated
Show resolved
Hide resolved
visualization/app/codeCharta/ui/customConfigs/customConfigList/customConfigList.component.scss
Outdated
Show resolved
Hide resolved
visualization/app/codeCharta/ui/customConfigs/customConfigList/customConfigList.component.scss
Outdated
Show resolved
Hide resolved
visualization/app/codeCharta/ui/customConfigs/customConfigList/customConfigList.component.scss
Outdated
Show resolved
Hide resolved
visualization/app/codeCharta/ui/customConfigs/customConfigList/customConfigList.component.scss
Outdated
Show resolved
Hide resolved
visualization/app/codeCharta/ui/customConfigs/customConfigList/customConfigList.component.ts
Outdated
Show resolved
Hide resolved
...codeCharta/ui/customConfigs/downloadCustomConfigsButton/downloadCustomConfigButton.module.ts
Outdated
Show resolved
Hide resolved
...arta/ui/customConfigs/downloadCustomConfigsButton/downloadCustomConfigsButton.component.scss
Outdated
Show resolved
Hide resolved
shaman-apprentice
approved these changes
May 9, 2022
…en new config is added) #2734
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!
|
|
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular migration of custom views list
Ref: #2318,
Close: #2734